Skip to content

v4: Set CMAKE_INSTALL_LIBDIR to lib#445

Merged
mathomp4 merged 2 commits intodevelopfrom
feature/v4-set-libdir
May 2, 2025
Merged

v4: Set CMAKE_INSTALL_LIBDIR to lib#445
mathomp4 merged 2 commits intodevelopfrom
feature/v4-set-libdir

Conversation

@mathomp4
Copy link
Copy Markdown
Member

@mathomp4 mathomp4 commented May 2, 2025

This PR sets CMAKE_INSTALL_LIBDIR to lib. This is needed as an update (soon) to ecbuild has an install(GNUInstallDirs) which sets library installs to lib64. But GEOS scripting assumes it'll be in lib.

@mathomp4 mathomp4 requested a review from a team as a code owner May 2, 2025 17:49
@github-actions
Copy link
Copy Markdown

github-actions bot commented May 2, 2025

This PR is being prevented from merging because you have not added one of our required labels: 0 diff, 0 diff trivial, Non 0-diff, 0 diff structural, 0-diff trivial, Not 0-diff, 0-diff, automatic, 0-diff uncoupled. Please add one so that the PR can be merged.

@mathomp4 mathomp4 added the 0 diff The changes in this pull request have verified to be zero-diff with the target branch. label May 2, 2025
@mathomp4 mathomp4 changed the base branch from main to develop May 2, 2025 17:50
@mathomp4 mathomp4 merged commit 1b1b8c2 into develop May 2, 2025
4 of 8 checks passed
@mathomp4 mathomp4 deleted the feature/v4-set-libdir branch May 22, 2025 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

0 diff The changes in this pull request have verified to be zero-diff with the target branch.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant