Skip to content

v11: Enforce allowed CMAKE_BUILD_TYPE #450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mathomp4 merged 1 commit into from
May 5, 2025
Merged

v11: Enforce allowed CMAKE_BUILD_TYPE #450

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,14 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

### Deprecated

## [3.60.0] - 2025-05-02
## [3.61.0] - 2025-05-06

### Changed
### Added

- Added code to enforce that we only allow `CMAKE_BUILD_TYPE` of Release, Debug, and Aggressive
- CMake can recognize others, but we maintain our own flags so we need to be careful

## [3.60.0] - 2025-05-02

### Added

Expand Down
7 changes: 7 additions & 0 deletions compiler/esma_compiler.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,13 @@ message(STATUS "Processor description: ${proc_description}")
list (APPEND CMAKE_MODULE_PATH "${CMAKE_CURRENT_LIST_DIR}/checks")
include(check_fortran_support)

## We only allow for three CMake Build Types
set(ALLOWED_BUILD_TYPES "Debug" "Release" "Aggressive")
if(NOT CMAKE_BUILD_TYPE IN_LIST ALLOWED_BUILD_TYPES)
string(REPLACE ";" ", " ALLOWED_BUILD_TYPES_STRING "${ALLOWED_BUILD_TYPES}")
message(FATAL_ERROR "The only allowed CMAKE_BUILD_TYPE are: ${ALLOWED_BUILD_TYPES_STRING}")
endif()

## Files with flags for Fortran compilers
list (APPEND CMAKE_MODULE_PATH "${CMAKE_CURRENT_LIST_DIR}/flags")
include ("${CMAKE_Fortran_COMPILER_ID}_Fortran")
Expand Down