Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the flags used for Flang now that we can build and run GEOS.
Release
For Release, we mainly do
-O3 -g -march=foo -funroll-loops -fstack-arraysas this seemed to be the best performance (but barely).Debug
For Debug we use:
-O0 -g -ffp-contract=offSave Temp Files
The
-fno-integrated-as -save-temps=objflag is how it appears we need to use-fsave-tempswith flang at present. @tarunprabhu has a fix in llvm/llvm-project#119624 but it's not yet merged, so for now, we keep the double flag.Update 1: We might not be able to use this. I'm having random issues with
save-tempsand Fortran codes with labels. ==> Reproducer found. it's a weird one.Update 2: Yeah, it's a bug. I filed an issue here:
llvm/llvm-project#184802
and for now, I'll just turn off the save-temps flags.
no FMA
The
-ffp-contract=offis the "no FMA" flag per @FlorianDeconinck . Makes sense to not do FMA on Debug. Makes the math map easier if we have to go assembly peeking.