Skip to content

pypromice.core.variables.radiation submodule added#352

Merged
PennyHow merged 20 commits intomainfrom
features/restructure-radiation
Sep 19, 2025
Merged

pypromice.core.variables.radiation submodule added#352
PennyHow merged 20 commits intomainfrom
features/restructure-radiation

Conversation

@PennyHow
Copy link
Member

@PennyHow PennyHow commented Sep 5, 2025

radiation submodule is for:

  • Converting radiometer measurements from engineering to physical units
  • Filter shortwave and longwave radiometer measurements
  • Correct shortwave radiation for station tilt and TOA irradiance
  • Calculate albedo
  • Calculate cloud coverage
  • Calculate surface temperature

As a result of the shortwave radiation correction and albedo calculation re-factoring, the routines related to station position/tilt were split and put into a submodule called pypromice.core.variables.station_pose. The station_pose submodule is for:

  • Calculating sun position relative to the station
  • Calculating sun angle relative to the station and the upper radiation sensor

!! Working in progress, not yet finished !!

@PennyHow PennyHow changed the title pypromice.core.variables.radiation submodule added [DRAFT] pypromice.core.variables.radiation submodule added Sep 5, 2025
@PennyHow PennyHow changed the title [DRAFT] pypromice.core.variables.radiation submodule added pypromice.core.variables.radiation submodule added Sep 9, 2025
@PennyHow
Copy link
Member Author

PennyHow commented Sep 9, 2025

Ready for review @ladsmund. Note the comments where I have highlighted things I am unsure about.

@PennyHow PennyHow requested a review from ladsmund September 9, 2025 15:54
@github-actions
Copy link

github-actions bot commented Sep 17, 2025

Dataset Comparison Report

✅ Datasets match perfectly!

No differences have been found between the datasets produced using the PR branch and the main branch.
⚠️ This report is generated from a small subset of test data that does not reflect all scenarios. Please check using more input data if you suspect changes to the output data have occurred.

@PennyHow PennyHow merged commit da39322 into main Sep 19, 2025
4 checks passed
@PennyHow PennyHow deleted the features/restructure-radiation branch September 19, 2025 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant