Merged
Conversation
ladsmund
force-pushed
the
feature/mcl_restructure
branch
from
ebc51dc to
eaba5b9
Compare
PennyHow
previously approved these changes
Sep 9, 2025
Member
PennyHow
left a comment
PennyHow
left a comment
There was a problem hiding this comment.
I just had a couple of comments but these can be looked into later. I'm happy for you to merge and continue.
PennyHow
previously approved these changes
Sep 12, 2025
- Introduced `io/ingestion/l0` as the central ingestion module. - Refactored parsing into version-specific methods with improved metadata handling: CSV default, CSV v1 and TOA5 file parsing - Implemented `_detect_file_type` for explicit input type detection. - Standardized naming: `load_l0` → `load_data`, `load_data` → `load_data_files`. - Enhanced TOA5 support with metadata extraction and per-variable attributes. - Simplified data flow by removing redundant code and unused functions. - Added unit tests in `test_ingest.py` to cover ingestion logic. - Improved logging, type hints, and docstrings for clarity.
…larity and maintainability.
Refactor: Standardize method and variable names for data loading operations and update corresponding test cases.
ladsmund
force-pushed
the
feature/mcl_restructure
branch
from
f2b4953 to
a15bd0b
Compare
PennyHow
approved these changes
Sep 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current pull request is no longer work in progress.