feat: allow short video uploads for segment suggestions - #70
Merged
Conversation
Adds a third kind alongside photo and voice, segment suggestions only (not chat attachments): a 50MB cap and mp4/quicktime/webm allow-list on the backend, enforced server-side too so a video can't land in the 48h-ephemeral chat_attachment store via a hand-crafted request. Reuses the existing photo file-picker flow rather than building a recording UI, since uploading an already-recorded clip is what "short videos should be fine" actually asked for. The Media tab gets a <video> player alongside its existing image/audio branches. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Go test coverage |
Coverage Report for frontend
File Coverage
|
||||||||||||||||||||||||||||||||||||||||||||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds video as a third kind for segment suggestions, alongside photo and voice -- not for chat attachments, per the earlier scope decision.
video/mp4/video/quicktime/video/webmallow-list, enforced server-side thatkind=videois rejected forpurpose=chat_attachment(not just omitted from the chat UI).SegmentSuggestion.vue: a third "Video" toggle reusing the existing photo file-picker flow (pick an existing clip, not record one live).<video>player alongside the existing image/audio branches.Test plan
go build ./... && go vet ./... && go test ./... -racecleanyarn type-check && yarn lint && yarn testclean, 311/311