Skip to content

fix: add spacing between the sender label and message in RadioChat - #72

Merged
JustSamuel merged 1 commit into
mainfrom
fix/radiochat-message-spacing
Aug 18, 2026
Merged

fix: add spacing between the sender label and message in RadioChat#72
JustSamuel merged 1 commit into
mainfrom
fix/radiochat-message-spacing

Conversation

@JustSamuel

Copy link
Copy Markdown
Collaborator

Summary

`RadioChat.vue`'s `"You:"` / `"Radio:"` label ran directly into the message text with no space at all (see screenshot in the linked report). `AdminChat.vue` already handles this correctly for its own `[Label]` prefix with an `ml-2` on the content -- this just applies the same fix instead of a different one-off, so the two chat views stay visually consistent.

Test plan

  • Frontend: `yarn type-check && yarn lint && yarn test` clean, 311/311 (including the existing test that renders a locally-echoed message and asserts its text)
  • Live click-through in a browser preview was blocked by an unrelated dev-session WebSocket handshake issue (raw WS connects fine; the chat's own handshake didn't complete) -- looks like leftover state from a long dev session, not something tied to this change. The exact rendering path this touches is covered by an existing passing test.

"You:" and "Radio:" ran directly into the message text with no gap
at all -- AdminChat.vue already solves this the same way for its own
[Label] prefix (an ml-2 on the content), so this just brings the
listener-facing chat in line with that instead of introducing a
third, different spacing approach.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@github-actions

Copy link
Copy Markdown

Coverage Report for frontend

Status Category Percentage Covered / Total
🔵 Lines 88.35% 1312 / 1485
🔵 Statements 85.91% 1440 / 1676
🔵 Functions 83.3% 454 / 545
🔵 Branches 81.39% 884 / 1086
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
frontend/src/components/RadioChat.vue 91.46% 88.23% 78.94% 94.59% 108-109, 113, 172, 189, 47-59
Generated in workflow #116 for commit a6d83bc by the Vitest Coverage Report Action

@JustSamuel
JustSamuel merged commit 24466b3 into main Aug 18, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant