Skip to content

fix: cycleway topic didn't ignore features that set value “no” #1018

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
joker234 merged 3 commits into from
May 8, 2026
Merged

fix: cycleway topic didn't ignore features that set value “no” #1018

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c462b40
fix: cycleway topic didn't ignore features that set value “no”
joker234 May 7, 2026
16dee76
chore: update CHANGELOG
joker234 May 7, 2026
1218fd3
Update ohsome_quality_api/topics/presets.yaml
joker234 May 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,10 @@
- build: upgrade pytest-approval and recreate approval files (4bdf27b5)
- Upgrade of pytest-approval included breaking changes to the approval
file naming scheme. All approval files are recreate (--auto-approve).
- fix: topic cycleway did include ways with cycleway features with value “no” ([1018])

[#1017] https://github.com/GIScience/ohsome-quality-api/pull/1017
[#1017]: https://github.com/GIScience/ohsome-quality-api/pull/1017
[#1018]: https://github.com/GIScience/ohsome-quality-api/pull/1018

## Release 1.17.1

Expand Down
16 changes: 8 additions & 8 deletions ohsome_quality_api/topics/presets.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,14 +171,14 @@ cycleway:
aggregation_type: length
filter: >-
((cycleway=* and cycleway!=no)
or (cycleway:both=*)
or (cycleway:right=*)
or (cycleway:left=*)
or (cycleway:right:lane=*)
or (cycleway:both:lane=*)
or (cycleway:left:lane=*)
or (cycleway:left:oneway=*)
or (cycleway:right:oneway=*)
or (cycleway:both=* and cycleway:both!=no)
or (cycleway:right=* and cycleway:right!=no)
or (cycleway:left=* and cycleway:left!=no)
or (cycleway:right:lane=* and cycleway:right:lane!=no)
or (cycleway:both:lane=* and cycleway:both:lane!=no)
or (cycleway:left:lane=* and cycleway:left:lane!=no)
or (cycleway:left:oneway=* and cycleway:left:oneway!=no)
or (cycleway:right:oneway=* and cycleway:right:oneway!=no)
or (highway=cycleway)
or (highway=path and bicycle=designated)
or (bicycle_road=yes)
Expand Down