Skip to content

Conversation

@josemanuelv
Copy link

Pull Request Checklist

  • 1. I have rebased the latest version of the main branch into my feature branch and all conflicts
    have been resolved.
  • 2. I have added information about the change/addition to functionality to the CHANGELOG.md file under the
    [Unreleased] heading.
  • 3. I have documented my code using JDocs tags.
  • 4. I have removed unnecessary commented out code, imports and System.out.println statements.
  • 5. I have written JUnit tests for any new methods/classes and ensured that they pass.
  • 6. I have created API tests for any new functionality exposed to the API.
  • 7. If changes/additions are made to the ors-config.json file, I have added these to the ors config documentation
    along with a short description of what it is for, and documented this in the Pull Request (below).
  • 8. I have built graphs with my code of the Heidelberg.osm.gz file and run the api-tests with all test passing
  • 9. I have referenced the Issue Number in the Pull Request (if the changes were from an issue).
  • 10. For new features or changes involving building of graphs, I have tested on a larger dataset
    (at least Germany), and the graphs build without problems (i.e. no out-of-memory errors).
  • 11. For new features or changes involving the graphbuilding process (i.e. changing encoders, updating the
    importer etc.), I have generated longer distance routes for the affected profiles with different options
    (avoid features, max weight etc.) and compared these with the routes of the same parameters and start/end
    points generated from the current live ORS.
    If there are differences then the reasoning for these MUST be documented in the pull request.
  • 12. I have written in the Pull Request information about the changes made including their intended usage
    and why the change was needed.
  • 13. For changes touching the API documentation, I have tested that the API playground renders correctly.

Fixes # .

Information about the changes

  • Key functionality added:
  • Reason for change:

Examples and reasons for differences between live ORS routes, and those generated from this pull request

Required changes to ors config (if applicable)

@sonarqubecloud
Copy link

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request adds Basque (Euskara) language translation support to OpenRouteService by introducing a new locale resource file and registering the language codes in the API enums.

Key changes:

  • New Basque translation file (ors_eu-ES.resources) with navigation instructions and directions
  • Registration of EU and EU_ES language codes in the APIEnums.Languages enum
  • Documentation of changes in CHANGELOG.md

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 9 comments.

File Description
ors-engine/src/main/resources/resources/locales/ors_eu-ES.resources New Basque translation file containing navigation instructions, directions, and maneuvers
ors-api/src/main/java/org/heigit/ors/api/APIEnums.java Adds EU and EU_ES language enum values to support Basque language in the API
CHANGELOG.md Documents the addition of Basque translation file and language enum updates

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

CHANGELOG.md Outdated
## [unreleased]

### Added
- translation file basque language ([#2206](https://github.com/GIScience/openrouteservice/issue/2206))
Copy link

Copilot AI Dec 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The URL pattern should be '/pull/2206' instead of '/issue/2206' to be consistent with other changelog entries. Most entries in this file reference pull requests, not issues.

Copilot uses AI. Check for mistakes.
Comment on lines 96 to 103
"default": "Enter {name}",
"headsign": "Enter {name} headed for {headsign}"
},
"transfer": {
"default": "Change to {name}",
"headsign": "Change to {name} headed for {headsign}"
},
"end": "Exit to {name}"
Copy link

Copilot AI Dec 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The public transport (pt) section is not translated to Basque and remains in English. While some other locale files (like Spanish) also leave this section untranslated, others (like German) provide translations. For a complete Basque translation, these strings should be translated to Basque to maintain consistency with the rest of the file.

Suggested change
"default": "Enter {name}",
"headsign": "Enter {name} headed for {headsign}"
},
"transfer": {
"default": "Change to {name}",
"headsign": "Change to {name} headed for {headsign}"
},
"end": "Exit to {name}"
"default": "{name} sartu",
"headsign": "{name} sartu, helmuga: {headsign}"
},
"transfer": {
"default": "{name} aldera aldatu",
"headsign": "{name} aldera aldatu, helmuga: {headsign}"
},
"end": "{name} irten"

Copilot uses AI. Check for mistakes.
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"pt": {
"start": {
"default": "Hartu {name}",
"headsign": "Hartu {name}, helmuga hau duena: {headsign}"
},
"transfer": {
"default": "Aldatu eta hartu {name}",
"headsign": "Aldatu eta hartu {name}, helmuga hau duena: {headsign}"
},
"end": "Irten hemen: {name}"
}

CHANGELOG.md Outdated
- "What you get" section to the JAR setup documentation and API reference to the docker setup documentation ([#2203](https://github.com/GIScience/openrouteservice/pull/2203))

### Changed
- adding basque language in APIEnum ([#2206](https://github.com/GIScience/openrouteservice/issue/2206))
Copy link

Copilot AI Dec 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The URL pattern should be '/pull/2206' instead of '/issue/2206' to be consistent with other changelog entries. Most entries in this file reference pull requests, not issues.

Suggested change
- adding basque language in APIEnum ([#2206](https://github.com/GIScience/openrouteservice/issue/2206))
- adding basque language in APIEnum ([#2206](https://github.com/GIScience/openrouteservice/pull/2206))

Copilot uses AI. Check for mistakes.
@aoles aoles self-assigned this Dec 16, 2025
@josemanuelv josemanuelv reopened this Dec 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants