feat: add road access restriction of type 'permit' #477
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a new road access restriction type "permit" and updates the corresponding color palette and internationalization support across multiple languages.
- Added a new dictionary entry for the "permit" restriction in ors-dictionary.js.
- Updated the color palette in the roadaccessrestrictions block with a new 'permit' color.
- Provided translations for the new "permit" type in several locale files and the translation source.
Reviewed Changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/resources/ors-dictionary.js | Added 'permit' key and updated color palette for road access restrictions. |
| src/resources/i18n/ors-dictionary.i18n.ro-ro.js | Added translation for permit. |
| src/resources/i18n/ors-dictionary.i18n.pt-br.js | Added translation for permit. |
| src/resources/i18n/ors-dictionary.i18n.it-it.js | Updated translations for permit and adjusted permissive wording. |
| src/resources/i18n/ors-dictionary.i18n.hu-hu.js | Added translation for permit. |
| src/resources/i18n/ors-dictionary.i18n.fr-fr.js | Updated translations for permit and adjusted permissive wording. |
| src/resources/i18n/ors-dictionary.i18n.es-es.js | Added translation for permit. |
| src/resources/i18n/ors-dictionary.i18n.en-us.js | Added translation for permit. |
| src/resources/i18n/ors-dictionary.i18n.de-de.js | Added translation for permit. |
| src/resources/i18n/ors-dictionary.i18n.cs-cz.js | Updated translations for permit and adjusted permissive wording. |
| docs/en-translation-source-merged.json | Updated translation source with permit key. |
Comments suppressed due to low confidence (1)
src/resources/ors-dictionary.js:82
- Ensure that unit tests are updated or added to cover the new 'permit' restriction type and its integration with the color palette logic.
'64': 'permit'
TheGreatRefrigerator
approved these changes
May 8, 2025
Collaborator
TheGreatRefrigerator
left a comment
TheGreatRefrigerator
left a comment
There was a problem hiding this comment.
Looks good.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds road access restriction type corresponding to OSM tag
access = permitthat has been introduced in GIScience/openrouteservice#2047.Additionally, the color palette for the different restriction types has been tweaked to better suit the qualitative nature of the presented data, as illustrated in the following screens.
Before
After