Skip to content

Add geocoding selection option for start and end point of route #223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

merydian
Copy link
Collaborator

No description provided.

@merydian merydian linked an issue Jan 23, 2024 that may be closed by this pull request
@merydian merydian requested a review from koebi January 23, 2024 14:40
@merydian
Copy link
Collaborator Author

Still need to make geocoding available when custom provider is used. Preferably, use public provider for geocoding, still custom provider for routing.

@merydian merydian marked this pull request as ready for review February 9, 2024 10:48
@MichaelsJP
Copy link
Member

MichaelsJP commented Nov 11, 2024

Nice.
I would reduce the two fields to one Geocode: [] or similar to always append the geocoded point to the end of the list. The point can be dragged to a custom location anyways.

To distinguish the points from the rest and since the points now come from a geocoded context, we could visualize the location to a geocoded point in the list. E.g. Point 2: 9.9, 49.9 | Geo: Heidelberg

@merydian
Copy link
Collaborator Author

One problem I see with only one geocode field is that people would need to know that points can be reordered in the list by drag & drop. Might not be intuitive to some. Maybe we can add a note somewhere?

@merydian merydian force-pushed the 205-add-geocoding-selection-option-for-start-and-end-point branch from 1c199b4 to 76822ed Compare May 19, 2025 13:03
@merydian merydian force-pushed the 205-add-geocoding-selection-option-for-start-and-end-point branch from c0dc526 to 037f20e Compare May 19, 2025 13:29
@koebi
Copy link
Collaborator

koebi commented May 19, 2025

Habe "Ringstraße 33 Heidelberg" eingegeben, und zack wars tot:

2025-05-19T15:35:02     WARNING    Traceback (most recent call last):
              File "/home/jschnell/.local/share/QGIS/QGIS3/profiles/default/python/plugins/ORStools/gui/ORStoolsDialog.py", line 278, in run_gui_control
              self.dlg.rubber_band.reset()
              ^^^^^^^^^^^^^^^^^^^^^^^^^^
             AttributeError: 'NoneType' object has no attribute 'reset'

@koebi
Copy link
Collaborator

koebi commented May 19, 2025

Vom Look-and-Feel her würde ich auch eher 'nen Knopf erwarten, mit dem ich den Geocoded Punkt jetzt in die Liste hinzufügen kann.
Weil ich aber ja nicht weiß, wo der ist, müsst ich dann irgendwie mit 'nem Doppelklick auf den Punkt springen können?

Tests wären auch noch cool :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add geocoding selection option for start and end point
3 participants