Replace eslint-plugin-import with eslint-plugin-import-x

Modern fork with better performance and fewer dependencies.
Updates eslint config to use import-x rules.

Co-Authored-By: Claude Haiku 4.5 <[email protected]>

Author: cmdcolin

eslint.config.mjs

@@ -1,6 +1,6 @@
 import eslint from '@eslint/js'
 import { defineConfig } from 'eslint/config'
-import importPlugin from 'eslint-plugin-import'
+import importPlugin from 'eslint-plugin-import-x'
 import eslintPluginUnicorn from 'eslint-plugin-unicorn'
 import tseslint from 'typescript-eslint'
 
@@ -110,9 +110,9 @@ export default defineConfig(
         },
       ],
 
-      'import/no-unresolved': 'off',
-      'import/extensions': ['error', 'ignorePackages'],
-      'import/order': [
+      'import-x/no-unresolved': 'off',
+      'import-x/extensions': ['error', 'ignorePackages'],
+      'import-x/order': [
         'error',
         {
           named: true,

package.json

@@ -66,7 +66,7 @@
     "buffer": "^6.0.3",
     "documentation": "^14.0.3",
     "eslint": "^10.2.1",
-    "eslint-plugin-import": "^2.32.0",
+    "eslint-plugin-import-x": "^4.16.2",
     "eslint-plugin-unicorn": "^64.0.0",
     "mock-fs": "^5.5.0",
     "prettier": "^3.8.3",

pnpm-lock.yaml

@@ -20,17 +20,17 @@ type ParsedIndex = Record<string, Slice[] | undefined>
 function addRecordToIndex(index: ParsedIndex, record: number[]) {
   const [seqId, start, span, containerStart, sliceStart, sliceBytes] = record
 
-  const s = seqId!
+  const s = seqId
   if (!index[s]) {
     index[s] = []
   }
 
   index[s].push({
-    start: start!,
-    span: span!,
-    containerStart: containerStart!,
-    sliceStart: sliceStart!,
-    sliceBytes: sliceBytes!,
+    start: start,
+    span: span,
+    containerStart: containerStart,
+    sliceStart: sliceStart,
+    sliceBytes: sliceBytes,
   })
 }
 

src/craiIndex.ts

@@ -46,7 +46,7 @@ function decodeBetaInline(
 
   // Fast path: reading exactly 8 bits when byte-aligned
   if (numBits === 8 && bitPosition === 7) {
-    const val = data[bytePosition]!
+    const val = data[bytePosition]
     cursor.bytePosition = bytePosition + 1
     return val - offset
   }
@@ -55,7 +55,7 @@ function decodeBetaInline(
   let val = 0
   for (let i = 0; i < numBits; i++) {
     val <<= 1
-    val |= (data[bytePosition]! >> bitPosition) & 1
+    val |= (data[bytePosition] >> bitPosition) & 1
     bitPosition -= 1
     if (bitPosition < 0) {
       bytePosition += 1

src/cramFile/codecs/beta.ts

@@ -17,31 +17,31 @@ export function batchDecodeItf8(buffer: Uint8Array) {
   const len = buffer.length
 
   while (pos < len) {
-    const b0 = buffer[pos]!
+    const b0 = buffer[pos]
     if (b0 < 0x80) {
       result[count++] = b0
       pos += 1
     } else if (b0 < 0xc0) {
-      result[count++] = ((b0 & 0x3f) << 8) | buffer[pos + 1]!
+      result[count++] = ((b0 & 0x3f) << 8) | buffer[pos + 1]
       pos += 2
     } else if (b0 < 0xe0) {
       result[count++] =
-        ((b0 & 0x1f) << 16) | (buffer[pos + 1]! << 8) | buffer[pos + 2]!
+        ((b0 & 0x1f) << 16) | (buffer[pos + 1] << 8) | buffer[pos + 2]
       pos += 3
     } else if (b0 < 0xf0) {
       result[count++] =
         ((b0 & 0x0f) << 24) |
-        (buffer[pos + 1]! << 16) |
-        (buffer[pos + 2]! << 8) |
-        buffer[pos + 3]!
+        (buffer[pos + 1] << 16) |
+        (buffer[pos + 2] << 8) |
+        buffer[pos + 3]
       pos += 4
     } else {
       result[count++] =
         ((b0 & 0x0f) << 28) |
-        (buffer[pos + 1]! << 20) |
-        (buffer[pos + 2]! << 12) |
-        (buffer[pos + 3]! << 4) |
-        (buffer[pos + 4]! & 0x0f)
+        (buffer[pos + 1] << 20) |
+        (buffer[pos + 2] << 12) |
+        (buffer[pos + 3] << 4) |
+        (buffer[pos + 4] & 0x0f)
       pos += 5
     }
   }
@@ -54,39 +54,39 @@ export function parseItf8(
   cursor: { bytePosition: number },
 ) {
   const offset = cursor.bytePosition
-  const countFlags = buffer[offset]!
+  const countFlags = buffer[offset]
   if (countFlags < 0x80) {
     cursor.bytePosition = offset + 1
     return countFlags
   }
   if (countFlags < 0xc0) {
     cursor.bytePosition = offset + 2
-    return ((countFlags & 0x3f) << 8) | buffer[offset + 1]!
+    return ((countFlags & 0x3f) << 8) | buffer[offset + 1]
   }
   if (countFlags < 0xe0) {
     cursor.bytePosition = offset + 3
     return (
       ((countFlags & 0x1f) << 16) |
-      (buffer[offset + 1]! << 8) |
-      buffer[offset + 2]!
+      (buffer[offset + 1] << 8) |
+      buffer[offset + 2]
     )
   }
   if (countFlags < 0xf0) {
     cursor.bytePosition = offset + 4
     return (
       ((countFlags & 0x0f) << 24) |
-      (buffer[offset + 1]! << 16) |
-      (buffer[offset + 2]! << 8) |
-      buffer[offset + 3]!
+      (buffer[offset + 1] << 16) |
+      (buffer[offset + 2] << 8) |
+      buffer[offset + 3]
     )
   }
   cursor.bytePosition = offset + 5
   return (
     ((countFlags & 0x0f) << 28) |
-    (buffer[offset + 1]! << 20) |
-    (buffer[offset + 2]! << 12) |
-    (buffer[offset + 3]! << 4) |
-    (buffer[offset + 4]! & 0x0f)
+    (buffer[offset + 1] << 20) |
+    (buffer[offset + 2] << 12) |
+    (buffer[offset + 3] << 4) |
+    (buffer[offset + 4] & 0x0f)
   )
 }
 
@@ -118,7 +118,7 @@ export default class ExternalCodec extends CramCodec<
     if (this.dataType === 'int') {
       const preDecoded = cursors.preDecodedIntBlocks?.get(this.blockContentId)
       if (preDecoded) {
-        return preDecoded.values[preDecoded.index++]!
+        return preDecoded.values[preDecoded.index++]
       }
       const contentBlock = blocksByContentId[this.blockContentId]
       if (!contentBlock) {
@@ -137,7 +137,7 @@ export default class ExternalCodec extends CramCodec<
           'attempted to read beyond end of block. this file seems truncated.',
         )
       }
-      return contentBlock.content[cursor.bytePosition++]!
+      return contentBlock.content[cursor.bytePosition++]
     }
   }
 

src/cramFile/codecs/external.ts

@@ -48,7 +48,7 @@ function decodeGammaInline(
   // Inline single-bit reads for the while loop
   // eslint-disable-next-line @typescript-eslint/no-unnecessary-condition
   while (true) {
-    const bit = (data[bytePosition]! >> bitPosition) & 1
+    const bit = (data[bytePosition] >> bitPosition) & 1
     bitPosition -= 1
     if (bitPosition < 0) {
       bytePosition += 1
@@ -67,7 +67,7 @@ function decodeGammaInline(
     // Optimized multi-bit read
     for (let i = 0; i < bitsToRead; i++) {
       readBits <<= 1
-      readBits |= (data[bytePosition]! >> bitPosition) & 1
+      readBits |= (data[bytePosition] >> bitPosition) & 1
       bitPosition -= 1
       if (bitPosition < 0) {
         bytePosition += 1

src/cramFile/codecs/gamma.ts

@@ -18,14 +18,14 @@ export function getBits(
 
   // Fast path: reading exactly 8 bits when byte-aligned
   if (numBits === 8 && cursor.bitPosition === 7) {
-    const val = data[cursor.bytePosition]!
+    const val = data[cursor.bytePosition]
     cursor.bytePosition += 1
     return val
   }
 
   // Fast path: reading exactly 1 bit
   if (numBits === 1) {
-    const val = (data[cursor.bytePosition]! >> cursor.bitPosition) & 1
+    const val = (data[cursor.bytePosition] >> cursor.bitPosition) & 1
     cursor.bitPosition -= 1
     if (cursor.bitPosition < 0) {
       cursor.bytePosition += 1
@@ -38,7 +38,7 @@ export function getBits(
   let val = 0
   for (let dlen = numBits; dlen; dlen--) {
     val <<= 1
-    val |= (data[cursor.bytePosition]! >> cursor.bitPosition) & 1
+    val |= (data[cursor.bytePosition] >> cursor.bitPosition) & 1
     cursor.bitPosition -= 1
     if (cursor.bitPosition < 0) {
       cursor.bytePosition += 1

src/cramFile/codecs/getBits.ts

@@ -17,7 +17,7 @@ function getBitsInline(
 
   // Fast path for single bit (common in huffman)
   if (numBits === 1) {
-    const val = (data[bytePosition]! >> bitPosition) & 1
+    const val = (data[bytePosition] >> bitPosition) & 1
     bitPosition -= 1
     if (bitPosition < 0) {
       bytePosition += 1
@@ -32,7 +32,7 @@ function getBitsInline(
   let val = 0
   for (let i = 0; i < numBits; i++) {
     val <<= 1
-    val |= (data[bytePosition]! >> bitPosition) & 1
+    val |= (data[bytePosition] >> bitPosition) & 1
     bitPosition -= 1
     if (bitPosition < 0) {
       bytePosition += 1
@@ -87,7 +87,7 @@ export default class HuffmanIntCodec extends CramCodec<
     // degenerate zero-length huffman code: special-case the decoding.
     // empty codeBook (no codes at all) is also valid for unused data series;
     // decode() will throw 'Huffman symbol not found' if such a codec is used.
-    if (this.sortedCodes.length > 0 && this.sortedCodes[0]!.bitLength === 0) {
+    if (this.sortedCodes.length > 0 && this.sortedCodes[0].bitLength === 0) {
       this._decode = this._decodeZeroLengthCode
     }
   }
@@ -99,8 +99,8 @@ export default class HuffmanIntCodec extends CramCodec<
     )
     for (let i = 0; i < this.parameters.numCodes; i++) {
       codes[i] = {
-        symbol: this.parameters.symbols[i]!,
-        bitLength: this.parameters.bitLengths[i]!,
+        symbol: this.parameters.symbols[i],
+        bitLength: this.parameters.bitLengths[i],
       }
     }
     // sort the codes by bit length and symbol value
@@ -113,7 +113,7 @@ export default class HuffmanIntCodec extends CramCodec<
       if (!this.codeBook[code.bitLength]) {
         this.codeBook[code.bitLength] = []
       }
-      this.codeBook[code.bitLength]!.push(code.symbol)
+      this.codeBook[code.bitLength].push(code.symbol)
     })
   }
 
@@ -159,7 +159,7 @@ export default class HuffmanIntCodec extends CramCodec<
 
     this.bitCodeToValue = new Array(maxBitCode + 1).fill(-1)
     for (let i = 0; i < this.sortedBitCodes.length; i += 1) {
-      this.bitCodeToValue[this.sortedCodes[i]!.bitCode] = i
+      this.bitCodeToValue[this.sortedCodes[i].bitCode] = i
     }
   }
 
@@ -178,7 +178,7 @@ export default class HuffmanIntCodec extends CramCodec<
 
   // the special case for zero-length codes
   _decodeZeroLengthCode() {
-    return this.sortedCodes[0]!.value
+    return this.sortedCodes[0].value
   }
 
   _decode(_slice: CramSlice, coreDataBlock: CramFileBlock, coreCursor: Cursor) {
@@ -187,22 +187,22 @@ export default class HuffmanIntCodec extends CramCodec<
     let prevLen = 0
     let bits = 0
     for (let i = 0; i < this.sortedCodes.length; i += 1) {
-      const length = this.sortedCodes[i]!.bitLength
+      const length = this.sortedCodes[i].bitLength
       const bitsToRead = length - prevLen
       if (bitsToRead > 0) {
         bits <<= bitsToRead
         bits |= getBitsInline(input, coreCursor, bitsToRead)
       }
       prevLen = length
       {
-        const index = this.bitCodeToValue[bits]!
+        const index = this.bitCodeToValue[bits]
         if (index > -1 && this.sortedBitLengthsByBitCode[index] === length) {
-          return this.sortedValuesByBitCode[index]!
+          return this.sortedValuesByBitCode[index]
         }
 
         for (
           let j = i;
-          this.sortedCodes[j + 1]!.bitLength === length &&
+          this.sortedCodes[j + 1].bitLength === length &&
           j < this.sortedCodes.length;
           j += 1
         ) {

src/cramFile/codecs/huffman.ts

@@ -48,7 +48,7 @@ function decodeSubexpInline(
   let numLeadingOnes = 0
   // eslint-disable-next-line @typescript-eslint/no-unnecessary-condition
   while (true) {
-    const bit = (data[bytePosition]! >> bitPosition) & 1
+    const bit = (data[bytePosition] >> bitPosition) & 1
     bitPosition -= 1
     if (bitPosition < 0) {
       bytePosition += 1
@@ -67,7 +67,7 @@ function decodeSubexpInline(
   let bits = 0
   for (let i = 0; i < b; i++) {
     bits <<= 1
-    bits |= (data[bytePosition]! >> bitPosition) & 1
+    bits |= (data[bytePosition] >> bitPosition) & 1
     bitPosition -= 1
     if (bitPosition < 0) {
       bytePosition += 1