re-enable eslint rules and fix violations

Re-enable 17 previously disabled rules that now have zero violations.
Fix node: protocol imports, top-level await, for-of loops, ternary
style. Add eqeqeq rule for strict equality.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Author: cmdcolin

eslint.config.mjs

@@ -24,7 +24,7 @@ export default defineConfig(
   eslintPluginUnicorn.configs.recommended,
   {
     rules: {
-      'no-empty': 'off',
+      eqeqeq: 'error',
       'no-console': [
         'warn',
         {
@@ -39,15 +39,9 @@ export default defineConfig(
         'error',
         { 'ts-expect-error': 'allow-with-description', 'ts-ignore': true },
       ],
-      '@typescript-eslint/no-explicit-any': 'warn',
+      '@typescript-eslint/no-explicit-any': 'error',
       '@typescript-eslint/no-non-null-assertion': 'off',
-      '@typescript-eslint/no-unsafe-member-access': 'off',
-      '@typescript-eslint/no-unsafe-argument': 'off',
-      '@typescript-eslint/no-unsafe-assignment': 'off',
-      '@typescript-eslint/no-unsafe-call': 'off',
-      '@typescript-eslint/no-unsafe-return': 'off',
-      '@typescript-eslint/require-await': 'off',
-      '@typescript-eslint/restrict-template-expressions': 'off',
+      '@typescript-eslint/restrict-template-expressions': ['error', { allowNumber: true }],
 
       '@typescript-eslint/no-unused-vars': [
         'warn',
@@ -60,18 +54,6 @@ export default defineConfig(
 
       'unicorn/filename-case': 'off',
       'unicorn/prevent-abbreviations': 'off',
-      'unicorn/no-null': 'off',
-      'unicorn/no-process-exit': 'off',
-      'unicorn/prefer-module': 'off',
-      'unicorn/prefer-top-level-await': 'off',
-      'unicorn/no-array-for-each': 'off',
-      'unicorn/no-for-loop': 'off',
-      'unicorn/prefer-spread': 'off',
-      'unicorn/consistent-function-scoping': 'off',
-      'unicorn/prefer-node-protocol': 'off',
-      'unicorn/no-nested-ternary': 'off',
-      'unicorn/no-useless-undefined': 'off',
-      'unicorn/prefer-ternary': 'off',
 
       'import/extensions': ['error', 'ignorePackages'],
       'import/no-unresolved': 'off',

src/TrixInputTransform.ts

@@ -1,4 +1,4 @@
-import { Transform } from 'stream'
+import { Transform } from 'node:stream'
 
 export class TrixInputTransform extends Transform {
   _transform(chunk: Buffer, _encoding: unknown, done: () => void) {

src/TrixOutputTransform.ts

@@ -1,4 +1,4 @@
-import { Transform } from 'stream'
+import { Transform } from 'node:stream'
 
 function elt(buff: string[], current: string) {
   return current + buff.map((b, i) => ` ${b},${i + 1}`).join('') + '\n'

src/bin.ts

@@ -8,12 +8,9 @@ if (!file) {
   console.log('usage: ixixx file.txt [out.ix] [out.ixx]')
   process.exit(1)
 }
-// eslint-disable-next-line @typescript-eslint/no-floating-promises
-;(async () => {
-  try {
-    await ixIxx(file, out1, out2)
-  } catch (error) {
-    console.error(error)
-    process.exit(1)
-  }
-})()
+try {
+  await ixIxx(file, out1, out2)
+} catch (error) {
+  console.error(error)
+  process.exit(1)
+}

src/externalSort.ts

@@ -1,8 +1,8 @@
-import fs from 'fs'
-import path from 'path'
-import { pipeline } from 'stream/promises'
+import fs from 'node:fs'
+import path from 'node:path'
+import { pipeline } from 'node:stream/promises'
 
-import type { Readable, Writable } from 'stream'
+import type { Readable, Writable } from 'node:stream'
 
 const EOF = Symbol('EOF')
 
@@ -92,7 +92,7 @@ function compare(a: string | typeof EOF, b: string | typeof EOF): number {
   if (b === EOF) {
     return -1
   }
-  return a < b ? -1 : a > b ? 1 : 0
+  return a < b ? -1 : (a > b ? 1 : 0)
 }
 
 function heapify(harr: HeapItem[], i: number, heapSize: number) {

src/index.ts

@@ -1,7 +1,7 @@
 import { makeIx, makeIxStream } from './makeIx.ts'
 import { makeIxx } from './makeIxx.ts'
 
-import type { Readable } from 'stream'
+import type { Readable } from 'node:stream'
 
 // this file (index.ts) is a translation of ixIxx.c from ucscGenomeBrowser/kent
 // the license of that file is reproduced below

src/makeIx.ts

@@ -1,7 +1,7 @@
-import { spawn } from 'child_process'
-import fs from 'fs'
-import { PassThrough } from 'stream'
-import { pipeline } from 'stream/promises'
+import { spawn } from 'node:child_process'
+import fs from 'node:fs'
+import { PassThrough } from 'node:stream'
+import { pipeline } from 'node:stream/promises'
 
 import { sync as commandExistsSync } from 'command-exists'
 import split2 from 'split2'
@@ -10,7 +10,7 @@ import { TrixInputTransform } from './TrixInputTransform.ts'
 import { TrixOutputTransform } from './TrixOutputTransform.ts'
 import { sortLinesExternal } from './sortLines.ts'
 
-import type { Readable } from 'stream'
+import type { Readable } from 'node:stream'
 
 const isWin =
   typeof process === 'undefined' ? false : process.platform === 'win32'
@@ -73,11 +73,9 @@ export async function makeIxStream(
   fileStream: Readable,
   outIxFilename: string,
 ) {
-  if (useExternalSort) {
-    await makeIxWithExternalSort(fileStream, outIxFilename)
-  } else {
-    await makeIxWithJsSort(fileStream, outIxFilename)
-  }
+  await (useExternalSort
+    ? makeIxWithExternalSort(fileStream, outIxFilename)
+    : makeIxWithJsSort(fileStream, outIxFilename))
 }
 
 export async function makeIx(inFile: string, outIndex: string) {

src/makeIxx.ts

@@ -1,7 +1,7 @@
-import { once } from 'events'
-import fs from 'fs'
-import readline from 'readline'
-import { finished } from 'stream/promises'
+import { once } from 'node:events'
+import fs from 'node:fs'
+import readline from 'node:readline'
+import { finished } from 'node:stream/promises'
 
 import { optimizePrefixSize } from './optimizePrefixSize.ts'
 import { binSize, getPrefix } from './util.ts'

src/optimizePrefixSize.ts

@@ -1,5 +1,5 @@
-import fs from 'fs'
-import readline from 'readline'
+import fs from 'node:fs'
+import readline from 'node:readline'
 
 import { binSize, getPrefix } from './util.ts'
 
@@ -63,9 +63,8 @@ export async function optimizePrefixSize(inIx: string) {
     const spaceIdx = line.indexOf(' ')
     const word = spaceIdx === -1 ? line : line.slice(0, spaceIdx)
 
-    for (let i = 0; i < stats.length; i++) {
+    for (const [i, s] of stats.entries()) {
       const prefixSize = MIN_PREFIX + i
-      const s = stats[i]!
       const curPrefix = getPrefix(word, prefixSize)
 
       if (curPrefix !== s.lastPrefix) {
@@ -87,8 +86,8 @@ export async function optimizePrefixSize(inIx: string) {
   }
 
   // Find first prefix size that meets heuristics
-  for (let i = 0; i < stats.length; i++) {
-    if (meetsHeuristics(stats[i]!, bytes)) {
+  for (const [i, s] of stats.entries()) {
+    if (meetsHeuristics(s, bytes)) {
       return MIN_PREFIX + i
     }
   }

src/sortLines.ts

@@ -1,10 +1,10 @@
-import fs from 'fs'
+import fs from 'node:fs'
 
 import tmp from 'tmp'
 
 import { externalSort } from './externalSort.ts'
 
-import type { Readable, Writable } from 'stream'
+import type { Readable, Writable } from 'node:stream'
 
 /**
  * Sort lines from input stream and write to output stream using external merge sort.