Don't create map

Author: cmdcolin

plugins/wiggle/src/MultiDensityRenderer/renderMultiDensity.ts

@@ -15,7 +15,7 @@ import type { Feature } from '@jbrowse/core/util'
 
 export async function renderMultiDensity(
   renderProps: MultiRenderArgsDeserialized,
-  features: Map<string, Feature>,
+  features: Feature[],
 ) {
   const {
     sources,
@@ -36,7 +36,7 @@ export async function renderMultiDensity(
     statusCallback,
     () =>
       renderToAbstractCanvas(width, height, renderProps, ctx => {
-        const groups = groupBy(features.values(), f => f.get('source'))
+        const groups = groupBy(features, f => f.get('source'))
         let feats: Feature[] = []
         ctx.save()
         for (const source of sources) {

plugins/wiggle/src/MultiLineRenderer/renderMultiLine.ts

@@ -15,7 +15,7 @@ import type { Feature } from '@jbrowse/core/util'
 
 export async function renderMultiLine(
   renderProps: MultiRenderArgsDeserialized,
-  features: Map<string, Feature>,
+  features: Feature[],
 ) {
   const {
     sources,
@@ -35,7 +35,7 @@ export async function renderMultiLine(
     statusCallback,
     () =>
       renderToAbstractCanvas(width, height, renderProps, ctx => {
-        const groups = groupBy(features.values(), f => f.get('source'))
+        const groups = groupBy(features, f => f.get('source'))
         let feats: Feature[] = []
         for (const source of sources) {
           const { reducedFeatures } = drawLine(ctx, {

plugins/wiggle/src/MultiRowLineRenderer/renderMultiRowLine.ts

@@ -15,7 +15,7 @@ import type { Feature } from '@jbrowse/core/util'
 
 export async function renderMultiRowLine(
   renderProps: MultiRenderArgsDeserialized,
-  features: Map<string, Feature>,
+  features: Feature[],
 ) {
   const {
     sources,
@@ -36,7 +36,7 @@ export async function renderMultiRowLine(
     statusCallback,
     () =>
       renderToAbstractCanvas(width, height, renderProps, ctx => {
-        const groups = groupBy(features.values(), f => f.get('source'))
+        const groups = groupBy(features, f => f.get('source'))
         let feats: Feature[] = []
         ctx.save()
         for (const source of sources) {

plugins/wiggle/src/MultiRowXYPlotRenderer/renderMultiRowXYPlot.ts

@@ -15,7 +15,7 @@ import type { Feature } from '@jbrowse/core/util'
 
 export async function renderMultiRowXYPlot(
   renderProps: MultiRenderArgsDeserialized,
-  features: Map<string, Feature>,
+  features: Feature[],
 ) {
   const {
     sources,
@@ -36,7 +36,7 @@ export async function renderMultiRowXYPlot(
     statusCallback,
     () =>
       renderToAbstractCanvas(width, height, renderProps, ctx => {
-        const groups = groupBy(features.values(), f => f.get('source'))
+        const groups = groupBy(features, f => f.get('source'))
         let allReducedFeatures: Feature[] = []
         ctx.save()
         for (const source of sources) {

plugins/wiggle/src/MultiXYPlotRenderer/renderMultiXYPlot.ts

@@ -15,7 +15,7 @@ import type { Feature } from '@jbrowse/core/util'
 
 export async function renderMultiXYPlot(
   renderProps: MultiRenderArgsDeserialized,
-  features: Map<string, Feature>,
+  features: Feature[],
 ) {
   const {
     sources,
@@ -35,7 +35,7 @@ export async function renderMultiXYPlot(
     statusCallback,
     () =>
       renderToAbstractCanvas(width, height, renderProps, ctx => {
-        const groups = groupBy(features.values(), f => f.get('source'))
+        const groups = groupBy(features, f => f.get('source'))
         let allReducedFeatures: Feature[] = []
         for (const source of sources) {
           const { reducedFeatures: reduced } = drawXY(ctx, {

plugins/wiggle/src/multiRendererHelper.ts

@@ -10,7 +10,7 @@ import type { Feature } from '@jbrowse/core/util'
 
 type RenderFeaturesFn = (
   props: MultiRenderArgsDeserialized,
-  features: Map<string, Feature>,
+  features: Feature[],
 ) => Promise<RenderReturn>
 
 export async function renderMultiWiggle(
@@ -26,11 +26,10 @@ export async function renderMultiWiggle(
   )
   const region = regions[0]!
 
-  const feats = await firstValueFrom(
+  const features = await firstValueFrom(
     (dataAdapter as BaseFeatureDataAdapter)
       .getFeatures(region, renderProps)
       .pipe(toArray()),
   )
-  const features = new Map(feats.map(f => [f.id(), f] as const))
   return renderFeatures(renderProps, features)
 }