Remove

Author: cmdcolin

component_tests/app-vite/src/main.tsx

@@ -1,11 +1,11 @@
-import React from 'react'
+import { StrictMode } from 'react'
 import { createRoot } from 'react-dom/client'
 import './index.css'
 import App from './App'
 
 const root = createRoot(document.getElementById('root')!)
 root.render(
-  <React.StrictMode>
+  <StrictMode>
     <App />
-  </React.StrictMode>,
+  </StrictMode>,
 )

component_tests/cgv-vite/src/main.tsx

@@ -1,11 +1,11 @@
-import React from 'react'
+import { StrictMode } from 'react'
 import { createRoot } from 'react-dom/client'
 import './index.css'
 import App from './App'
 
 const root = createRoot(document.getElementById('root')!)
 root.render(
-  <React.StrictMode>
+  <StrictMode>
     <App />
-  </React.StrictMode>,
+  </StrictMode>,
 )

component_tests/lgv-vite/src/main.tsx

@@ -1,11 +1,11 @@
-import React from 'react'
+import { StrictMode } from 'react'
 import { createRoot } from 'react-dom/client'
 import './index.css'
 import App from './App'
 
 const root = createRoot(document.getElementById('root')!)
 root.render(
-  <React.StrictMode>
+  <StrictMode>
     <App />
-  </React.StrictMode>,
+  </StrictMode>,
 )

packages/core/DEVELOPERS.md

@@ -1,14 +1,28 @@
 # @jbrowse/core Developer Guide
 
+## Package Design
+
+This package has **no main entry point**. It is designed exclusively for subpath
+imports:
+
+```typescript
+// Correct usage
+import PluginManager from '@jbrowse/core/PluginManager'
+import { ConfigurationSchema } from '@jbrowse/core/configuration'
+
+// This will error - no default export
+import '@jbrowse/core' // ERR_PACKAGE_PATH_NOT_EXPORTED
+```
+
 ## package.json Structure
 
-This package uses a dual-mode configuration to support both monorepo development and
-external consumers.
+This package uses a dual-mode configuration to support both monorepo development
+and external consumers.
 
 ### Exports Field
 
-The `exports` field defines subpath imports like `@jbrowse/core/PluginManager`. During
-development, these point to source TypeScript files:
+The `exports` field defines subpath imports like `@jbrowse/core/PluginManager`.
+During development, these point to source TypeScript files:
 
 ```json
 "exports": {
@@ -19,8 +33,8 @@ development, these point to source TypeScript files:
 
 ### publishConfig
 
-When the package is published to npm, the `publishConfig` section overrides the exports
-to point to compiled output:
+When the package is published to npm, the `publishConfig` section overrides the
+exports to point to compiled output:
 
 ```json
 "publishConfig": {
@@ -35,9 +49,10 @@ to point to compiled output:
 
 ### typesVersions (for moduleResolution "node" consumers)
 
-The `exports` field is only supported by TypeScript with `moduleResolution` set to
-`bundler`, `node16`, or `nodenext`. For consumers using the legacy `moduleResolution: "node"`,
-we include a `typesVersions` field in `publishConfig`:
+The `exports` field is only supported by TypeScript with `moduleResolution` set
+to `bundler`, `node16`, or `nodenext`. For consumers using the legacy
+`moduleResolution: "node"`, we include a `typesVersions` field in
+`publishConfig`:
 
 ```json
 "publishConfig": {
@@ -49,8 +64,8 @@ we include a `typesVersions` field in `publishConfig`:
 }
 ```
 
-This tells TypeScript where to find type declarations for subpath imports even when
-the `exports` field is not being read.
+This tells TypeScript where to find type declarations for subpath imports even
+when the `exports` field is not being read.
 
 ## Generating Exports
 
@@ -61,13 +76,13 @@ auto-generated by scanning the codebase for `@jbrowse/core/*` imports:
 pnpm generate:exports
 ```
 
-This script (`scripts/generateExports.mjs`) finds all imports of `@jbrowse/core/*`
-across the monorepo and generates the appropriate mappings.
+This script (`scripts/generateExports.mjs`) finds all imports of
+`@jbrowse/core/*` across the monorepo and generates the appropriate mappings.
 
 ## Module Resolution Summary
 
-| Consumer Environment | How it resolves `@jbrowse/core/PluginManager` |
-|---------------------|-----------------------------------------------|
-| Monorepo (bundler mode) | Uses `exports` field pointing to `src/*.ts` |
-| External (bundler/node16/nodenext) | Uses `publishConfig.exports` pointing to `esm/*.js` |
-| External (node mode) | Uses `typesVersions` for types, `exports` for runtime |
+| Consumer Environment               | How it resolves `@jbrowse/core/PluginManager`         |
+| ---------------------------------- | ----------------------------------------------------- |
+| Monorepo (bundler mode)            | Uses `exports` field pointing to `src/*.ts`           |
+| External (bundler/node16/nodenext) | Uses `publishConfig.exports` pointing to `esm/*.js`   |
+| External (node mode)               | Uses `typesVersions` for types, `exports` for runtime |

packages/core/package.json

@@ -19,10 +19,7 @@
     "directory": "packages/core"
   },
   "author": "JBrowse Team",
-  "main": "dist/index.js",
-  "types": "dist/index.d.ts",
   "exports": {
-    ".": "./src/index.ts",
     "./BaseFeatureWidget": "./src/BaseFeatureWidget/index.ts",
     "./BaseFeatureWidget/BaseFeatureDetail": "./src/BaseFeatureWidget/BaseFeatureDetail/index.tsx",
     "./BaseFeatureWidget/BaseFeatureDetail/Attributes": "./src/BaseFeatureWidget/BaseFeatureDetail/Attributes.tsx",
@@ -191,13 +188,7 @@
   },
   "publishConfig": {
     "access": "public",
-    "main": "esm/index.js",
-    "types": "esm/index.d.ts",
     "exports": {
-      ".": {
-        "types": "./esm/index.d.ts",
-        "import": "./esm/index.js"
-      },
       "./BaseFeatureWidget": {
         "types": "./esm/BaseFeatureWidget/index.d.ts",
         "import": "./esm/BaseFeatureWidget/index.js"
@@ -967,6 +958,9 @@
         ],
         "ReExports/list": [
           "esm/ReExports/list.d.ts"
+        ],
+        "util/fileHandleStore": [
+          "esm/util/fileHandleStore.d.ts"
         ]
       }
     }

packages/core/scripts/generateExports.mjs

@@ -98,17 +98,12 @@ console.log(`Found ${imports.length} unique @jbrowse/core import paths`)
 
 // Generate dev exports (pointing to src)
 // Using simple string format since import/require point to same .ts file
-const devExports = {
-  '.': './src/index.ts',
-}
+// Note: No "." entry - this package is designed for subpath imports only
+const devExports = {}
 
 // Generate publish exports (pointing to esm)
-const publishExports = {
-  '.': {
-    types: './esm/index.d.ts',
-    import: './esm/index.js',
-  },
-}
+// Note: No "." entry - this package is designed for subpath imports only
+const publishExports = {}
 
 // Generate typesVersions for moduleResolution "node" consumers
 // This allows TypeScript to resolve subpath imports even without exports field support

products/jbrowse-cli/src/utils.ts

@@ -198,7 +198,7 @@ function wrapText(text: string, width: number, indent: string) {
       }
     }
   }
-  return lines.join('\n' + indent)
+  return lines.join(`\n${indent}`)
 }
 
 export function printHelp({