Remove the async keyword from BaseLinearDisplayModel (#5036)

Author: cmdcolin

plugins/alignments/src/LinearPileupDisplay/SharedLinearPileupDisplayMixin.ts

@@ -377,9 +377,7 @@ export function SharedLinearPileupDisplayMixin(
                   icon: MenuOpenIcon,
                   onClick: () => {
                     self.clearFeatureSelection()
-                    self.selectFeature(feat).catch((e: unknown) => {
-                      getSession(self).notifyError(`${e}`, e)
-                    })
+                    self.selectFeature(feat)
                   },
                 },
                 {
@@ -436,7 +434,7 @@ export function SharedLinearPileupDisplayMixin(
                   )) as { feature: SimpleFeatureSerialized | undefined }
 
                   if (isAlive(self) && feature) {
-                    await self.selectFeature(new SimpleFeature(feature))
+                    self.selectFeature(new SimpleFeature(feature))
                   }
                 }
               } catch (e) {

plugins/linear-genome-view/src/BaseLinearDisplay/models/BaseLinearDisplayModel.tsx

@@ -234,29 +234,38 @@ function stateModelFactory() {
       /**
        * #action
        */
-      async selectFeature(feature: Feature) {
+      selectFeature(feature: Feature) {
         const session = getSession(self)
         if (isSessionModelWithWidgets(session)) {
           const { rpcManager } = session
           const sessionId = getRpcSessionId(self)
           const track = getContainingTrack(self)
           const view = getContainingView(self)
           const adapterConfig = getConf(track, 'adapter')
-          const descriptions = await rpcManager.call(
-            sessionId,
-            'CoreGetMetadata',
-            {
-              adapterConfig,
-            },
-          )
-          session.showWidget(
-            session.addWidget('BaseFeatureWidget', 'baseFeature', {
-              featureData: feature.toJSON(),
-              view,
-              track,
-              descriptions,
-            }),
-          )
+
+          // eslint-disable-next-line @typescript-eslint/no-floating-promises
+          ;(async () => {
+            try {
+              const descriptions = await rpcManager.call(
+                sessionId,
+                'CoreGetMetadata',
+                {
+                  adapterConfig,
+                },
+              )
+              session.showWidget(
+                session.addWidget('BaseFeatureWidget', 'baseFeature', {
+                  featureData: feature.toJSON(),
+                  view,
+                  track,
+                  descriptions,
+                }),
+              )
+            } catch (e) {
+              console.error(e)
+              getSession(e).notifyError(`${e}`, e)
+            }
+          })()
         }
 
         if (isSelectionContainer(session)) {
@@ -335,11 +344,7 @@ function stateModelFactory() {
                   icon: MenuOpenIcon,
                   onClick: () => {
                     if (self.contextMenuFeature) {
-                      self
-                        .selectFeature(self.contextMenuFeature)
-                        .catch((e: unknown) => {
-                          getSession(e).notifyError(`${e}`, e)
-                        })
+                      self.selectFeature(self.contextMenuFeature)
                     }
                   },
                 },
@@ -373,9 +378,7 @@ function stateModelFactory() {
             } else {
               const feature = self.features.get(f)
               if (feature) {
-                self.selectFeature(feature).catch((e: unknown) => {
-                  getSession(e).notifyError(`${e}`, e)
-                })
+                self.selectFeature(feature)
               }
             }
           },