Fix: Synchronization bug when dumping swapchain in DX12 path #155
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is currently a synchronization bug when dumping the swapchain to file in the DX12 path. The cause of the bug is that a semaphore is signaled before the execution of the command buffer responsible for copying the render target into a buffer on a readback heap. Instead, the semaphore should be signaled after the command buffer execution.
Although the bug would be fixed by moving line 225 to line 230, the code becomes more readable by reusing already existing code for handling immediate execution of command buffers. This is what the Vulkan path already does.
Furthermore, a transition barrier was added after the copy operation to transition the render target back to a Present state, similar to what the Vulkan path does.