refactorisation of AutoCropCalling, and PATHS#17
Conversation
…sation of AutoCropCalling
| IJ.error("Cannot run autocrop on " + file.getName()); | ||
| } finally { | ||
| // GARANTIE : le latch décrémente toujours, même en cas d'erreur | ||
| latch.countDown(); |
| for (File file : files) { | ||
| generalInfoBuilder.append(cropInfo.get(file.getName())); | ||
| if (cropInfo.containsKey(file.getName())) { | ||
| generalInfoBuilder.append(cropInfo.get(file.getName())); |
There was a problem hiding this comment.
This is code improvement unrelated to methods refactoring.
Instead of a check with "if", this could probably also be used:
generalInfoBuilder.append(cropInfo.getOrDefault(file.getName(), ""));
| private String processAutoCropWorkflowOMERO(AutoCrop autoCrop, ImageWrapper image, Long[] outputsDatImages, | ||
| Client client, String prefix, long outputProject) | ||
| throws AccessException, ServiceException, ExecutionException, OMEROServerError, IOException { | ||
| String fileImg = image.getName(); |
There was a problem hiding this comment.
Why the difference between "local" and "OMERO" workflows?
Autocrop is created in "process" for local, but is passed as an argument for OMERO?
| } catch (ServiceException | AccessException | ExecutionException e) { | ||
| LOGGER.error("Cannot create AutoCrop for image: {}", fileImg, e); | ||
| // Si l'initialisation échoue, on débloque le latch ici ! | ||
| latch.countDown(); |
There was a problem hiding this comment.
Potential bugfix but unrelated to current objective, and could introduce other bugs.
ppouchin
left a comment
ppouchin
left a comment
There was a problem hiding this comment.
The code refactoring looks promising, but there are code modifications unrelated to the current objective that could alter how the program runs.
These bugfixes could be interesting but should be pushed separately.
Moreover, there could be more code homogeneity between local and OMERO workflows.
…to refactoriser_et_unifier
…cul pour les deux
…MERO sur la methode compute
load et constructeur uniques
2 participants
refactorisation of AutoCropCalling . Add Mermaid call graph diagrams for all menu components.