Give distinct CatalogRecords distinct synthetic identifiers - #930
Open
soroush5 wants to merge 1 commit into
Open
Give distinct CatalogRecords distinct synthetic identifiers#930soroush5 wants to merge 1 commit into
soroush5 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
backfill_catalog_record_identifierssynthesized the @id fromprimaryTopic|modifiedonly, so two different records sharing those fields (or both missing them) got the exact same @id, andfilter_duplicate_identifiersthen wrongly dropped all but the first — silent data loss.Now hashes the full record content: distinct records get distinct @ids, byte-identical records still collapse (true duplicates), and ids stay stable across runs.
TestBackfillCatalogRecordIdentifiers(5 existing + 1 new): 6 passed.