Open
Conversation
remove the option for null values for 'label' and add 'label' to the required array
|
note for later the " I don't know why they would" argument does not hold a ton of water to me. I truly believe CDOs and their staff will appreciate less opportunities for error unless there is a need for flexibility. |
Author
|
Activity Usage in Schema
|
Author
|
Also, I should note that this needs to be run through Prettier before being merged |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Should resolve: #81
Documentation: Activity
Changes:
nullvalues forlabeland addlabelto therequiredarrayFor Discussion
Does the above change make sense? If so, should it be extended across the other DCAT-US 3.0 classes? Is the change generalizable or a class-by-class determination?
Copied from issue:
I think this issue is just one example of a broader problem that I see with many of the classes. That being, many of them have no required/mandatory properties. As such, although I don't know why they would, a user/catalog owner could create instances of some of the DCAT-US 3.0 classes that are effectively "empty" and that provide no information to the viewer, but which would hypothetically pass validation.