Skip to content

Api connecting/fix problem with verification page and fix undefine problem in ListtingAdmin panel#59

Merged
eng-raghadsami merged 4 commits into
devfrom
ApiConnecting
Mar 6, 2026
Merged

Api connecting/fix problem with verification page and fix undefine problem in ListtingAdmin panel#59
eng-raghadsami merged 4 commits into
devfrom
ApiConnecting

Conversation

@eng-raghadsami

@eng-raghadsami eng-raghadsami commented Mar 6, 2026

Copy link
Copy Markdown
Collaborator

Summary by CodeRabbit

  • Updates
    • Simplified post-login navigation flow—users are now routed directly to their home or profile instead of intermediate verification steps.
    • Updated email and identity verification completion flows to route users to their profile.
    • Enhanced backend service integrations for improved data handling and API consistency.

@vercel

vercel Bot commented Mar 6, 2026

Copy link
Copy Markdown

@coderabbitai

coderabbitai Bot commented Mar 6, 2026

Copy link
Copy Markdown

Caution

Review failed

Pull request was closed or merged during review

Walkthrough

This PR removes the email/phone/identity verification flow from the application. It eliminates the VERIFY route constant, deletes the VerifyPage component, removes the protected /verify route, and updates post-login/registration navigation to redirect to HOME or PROFILE instead of verification pages. Additional service layer updates to admin and authentication APIs are included.

Changes

Cohort / File(s) Summary
Route Configuration
src/constants/routes.ts, src/routes/routes.tsx
Removed VERIFY route constant and deleted the protected "/verify" route entry that previously loaded VerifyPage within AuthGuard wrapper.
Verification Pages
src/pages/VerifyPage/VerifyPage.tsx, src/pages/EmailVerificationPage/EmailVerificationPage.tsx, src/pages/IdentityVerificationPage/IdentityVerificationStatusPage.tsx
Deleted VerifyPage component entirely. Updated EmailVerificationPage and IdentityVerificationStatusPage to redirect to PROFILE instead of VERIFY on success.
Authentication Pages
src/pages/LoginPage/LoginPage.tsx, src/pages/RegisterPage/RegisterPage.tsx
Removed verification status checks (email/phone verification) from post-login and post-registration flows. Both now redirect to HOME instead of conditionally routing to VERIFY.
Service Updates
src/services/admin-listings.service.ts, src/services/admin.service.ts, src/services/auth.service.ts
Updated API implementations: admin-listings replaced apiClient with api and restructured response handling; admin.service returns full response object instead of data payload; auth.service changed updateProfile from PUT to PATCH method.

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~50 minutes

Possibly related PRs

Suggested reviewers

  • MahmoudHamo1
  • ShadiSbaih
🚥 Pre-merge checks | ✅ 1 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
Title check ❓ Inconclusive The title is vague and contains grammatical issues; it mentions 'verification page' and 'ListtingAdmin panel' but doesn't clearly convey the main changes (removing verify page, redirecting post-login/registration to HOME, updating API calls). Revise the title to clearly describe the primary objective, such as 'Remove verify page and redirect authentication flows to home' or 'Simplify post-auth navigation and update API integrations'.
✅ Passed checks (1 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch ApiConnecting

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants