Lollipop support #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On Lollipop, the path to the Settings app is /system/priv-app/Settings/Settings.apk
This commit copies the data APK to a similarly-named path on devices with their ro.build.version.release's X.Y[.Z] version number's X
greater than or equal to 5 (lollipop and up).
This is build property MAY not exist or have values of the nature assumed by this commit for all OEMs, but this definitely covers
AOSP and popular open source derivatives there-of.
The backup script's list-files function now has BOTH possible priv-app paths listed.
This works because backup_file and restore_file no-op in the case that a file does not exist.
…ic+appropriate (so the lollipop path isn't /system/priv-app/roothelper/roothelper.apk) And remove spaces to prevent issues when compiling inline with AOSP
|
Prolly worth testing on lollipop when compiled traditionally before merging... I've been testing with this compiled directly to /system/priv-app inline with a lollipop ota zip |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Works when compiled inline with AOSP 5.1.1 directly to /system/priv-app/GSamBatteryMonitor-RootHelper/GSamBatteryMonitor-RootHelper.apk, but I haven't verified its ability to transplant itself to that location conditionally when initially installed as a non-privileged data app
The second commit is just renaming things to avoid an ambiguous "/system/priv-app/companion/rootcompanion.apk" destination for lollipop+ pathing, and is probably not "necessary".