Skip to content

Yipiii... another batch of recipes #1228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 33 commits into from
May 31, 2025

Conversation

EnderProyects
Copy link
Contributor

@EnderProyects EnderProyects commented Mar 31, 2025

Add recipes for all terracota in furnace, add recipes for stripped logs in the extruder as talked in git-dev, add recipes for obtaing some sapplings and wither rose
image
image
image
image
image
image
image
image
image
image
image
image
image
image
image
image
...
image
image
image

@Nockyx
Copy link
Contributor

Nockyx commented Mar 31, 2025

In my opinion should:

Change the Glass Recipe to use amethyst shard, and use oredict so the gt one works.

Change the Warped plant recipe, it's overly complicated

Not make the magrove need botania flowers, no reason to gate a vanilla tree on magic

@EnderProyects
Copy link
Contributor Author

The plants you can get by exploration, and once you get one you can get a ton, by farming or by using TGS, just added recipes so people that plays in old world generation or customs runs can get them

@EnderProyects
Copy link
Contributor Author

changed recipes

@Dream-Master Dream-Master requested a review from a team April 1, 2025 11:25
@Dream-Master Dream-Master added the 🚧 Testing on Zeta Do not merge yet, testing this PR on Zeta label Apr 1, 2025
@EnderProyects
Copy link
Contributor Author

EnderProyects commented Apr 3, 2025

Added recipes for decorative amethyst and tuff
image
image
image
image
image

@ReignOfFROZE
Copy link
Contributor

Centrifuging a rock doesn't really make a whole lot of sense for the tuff centrifuging... why not use (or add if it doesn't exist already) the dust to be in line with every other rock dust centrifuging

@ReignOfFROZE
Copy link
Contributor

Also, what are those liquids in the amethyst autoclave recipes?

@YannickMG
Copy link
Contributor

If it's not related to progression, it's probably better to re-use existing fluids (or avoid them altogether if they're just there to add flavor) so players don't have to juggle yet another line.

In the case of the autoclave is there any reason not to use the regular autoclave fluids?

As for this recipe to make Tuff.. I'm having some trouble understanding the point of it.

        GTValues.RA.stdBuilder()
                .itemInputs(
                        getModItem(BiomesOPlenty.ID, "ash", 1, 0, missing),
                        getModItem(Botania.ID, "stone", 1, 1, missing),
                        GTOreDictUnificator.get(OrePrefixes.dust, Materials.Netherrack, 64L),
                        GTUtility.copyAmount(0, GTOreDictUnificator.get(OrePrefixes.lens, Materials.NetherStar, 1)))
                .fluidInputs(new FluidStack(FluidRegistry.getFluid("ic2pahoehoelava"), 3000))
                .itemOutputs(getModItem(EtFuturumRequiem.ID, "tuff", 1, 0, missing)).duration(20 * SECONDS)
                .eut(TierEU.RECIPE_LV).addTo(laserEngraverRecipes);

For one thing, the laser engraver has no business making soils/stones. Then it requires Biomes of Plenty Ash, Botania stone only obtainable through Magic or through Blue Ice for some reason in the Block Breaker and Pahoehoe Lava from the output of a Thermal Boiler..... All that to make a single block of Tuff which you can find unlimited amounts of in the overworld?

I get that this makes for a "fun looking" line of recipes in order to get to a final product, but this final product is incredibly ordinary and in no way deserves this level of complexity to be craftable.

All this to say not every block needs to have a recipe. If the intent here is that you didn't want players to be able to loop Tuff infinitely from the materials it's made of you could simply forego having a recipe altogether.

Also yes as mentioned let's give Tuff a dust and use that if we want to centrifuge it. It's hard enough to be mined with a pickaxe after all.

All that being said, you obviously have your reasons for why you like making recipes these ways. It might be good to discuss the guiding principles you are using for recipe design in the EFR AOI and might help you align your work with what's more likely to be accepted.

@Caedis
Copy link
Member

Caedis commented Apr 4, 2025

Also, try not to use any IC2 items/fluids as we are trying to drop IC2

@EnderProyects
Copy link
Contributor Author

EnderProyects commented Apr 4, 2025

Also, what are those liquids in the amethyst autoclave recipes?

1 to 1 mineral water, amethyst to big chunk vibrant alloy

@EnderProyects
Copy link
Contributor Author

The reason is fortune applies to shards, also I whanted to add something in line with real shards growing, mineral water suits in there instead of just water

@seventh-june
Copy link

Tuff's recipe is a bit too overdone/expensive for just a naturally-occurring building block IMO- tuff is mostly just compressed volcanic ash and glass so i feel like the byproducts/crafting of it should just be dark ashes and maybe obsidian dust/basaltic mineral sand, then again I also don't know what you have it made of right now

@EnderProyects
Copy link
Contributor Author

Tuff recipe is already removed on my end, a meteor will be added

@ReignOfFROZE
Copy link
Contributor

Tuff recipe is already removed on my end, a meteor will be added

I don't really see the need for a meteor? Is tuff something that's going to be required en masse for crafting (such as a singularity or something)? We don't have meteors dedicated to being methods of producing granite or other basic stones so I don't see why tuff is an outlier. Also, it's a naturally generating stone, and if it's anything like vanilla world gen, you're going to have way more of it than you want from mining anyways

@LazyFleshWasTaken
Copy link
Contributor

Tuff recipe is already removed on my end, a meteor will be added

I don't really see the need for a meteor? Is tuff something that's going to be required en masse for crafting (such as a singularity or something)? We don't have meteors dedicated to being methods of producing granite or other basic stones so I don't see why tuff is an outlier. Also, it's a naturally generating stone, and if it's anything like vanilla world gen, you're going to have way more of it than you want from mining anyways

tuff only generates around geodes, so its not all that bountiful. Having some process of creating it yourself is far more convenient. Compressing ash seems fine imo.

@EnderProyects
Copy link
Contributor Author

Tuff recipe is already removed on my end, a meteor will be added

I don't really see the need for a meteor? Is tuff something that's going to be required en masse for crafting (such as a singularity or something)? We don't have meteors dedicated to being methods of producing granite or other basic stones so I don't see why tuff is an outlier. Also, it's a naturally generating stone, and if it's anything like vanilla world gen, you're going to have way more of it than you want from mining anyways

We have meteors for all granites, what are you saying lmao, there are meteors for many decorative blocks and stuff

@ReignOfFROZE
Copy link
Contributor

Tuff recipe is already removed on my end, a meteor will be added

I don't really see the need for a meteor? Is tuff something that's going to be required en masse for crafting (such as a singularity or something)? We don't have meteors dedicated to being methods of producing granite or other basic stones so I don't see why tuff is an outlier. Also, it's a naturally generating stone, and if it's anything like vanilla world gen, you're going to have way more of it than you want from mining anyways

We have meteors for all granites, what are you saying lmao, there are meteors for many decorative blocks and stuff

My bad, there is a meteor for all of the granites, I missed that. I still think a meteor is overkill, though. LazyFlesh's suggestion seems more reasonable

@EnderProyects
Copy link
Contributor Author

EnderProyects commented May 8, 2025

image

Tuff dust

Caedis added a commit that referenced this pull request May 23, 2025
Merged PRs:
	#1227
	#1228
	#1242
	#1261
	#1266
	#1267

Failed PRs:
	#1221: Failed to merge
	#1268: Build failed
	#1269: Build failed
Caedis
Caedis previously requested changes May 29, 2025
Caedis added a commit that referenced this pull request May 29, 2025
Merged PRs (no # means no changes):
	#1268
	#1221
	#1270
	#1227
	#1279

Failed PRs:
	#1228: Failed to merge
	#1261: Build failed
Dream-Master
Dream-Master previously approved these changes May 31, 2025
@Dream-Master Dream-Master dismissed their stale review May 31, 2025 11:00

need to check 2 more recipes

@Caedis Caedis dismissed their stale review May 31, 2025 11:40

Good now

@Dream-Master Dream-Master merged commit abb9471 into GTNewHorizons:master May 31, 2025
4 checks passed
@Dream-Master Dream-Master removed the 🚧 Testing on Zeta Do not merge yet, testing this PR on Zeta label May 31, 2025
@EnderProyects EnderProyects deleted the Batch-of-EFR-blocks branch June 1, 2025 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants