Conversation
thehoblit
marked this pull request as draft
May 26, 2026 03:23
thehoblit
marked this pull request as ready for review
May 27, 2026 04:58
thehoblit
marked this pull request as draft
June 8, 2026 04:10
thehoblit
marked this pull request as ready for review
June 8, 2026 04:22
3 tasks
thehoblit
added
✔️ Tested in full GTNH instance
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes GTNewHorizons/GT-New-Horizons-Modpack#22418
Fixes swapping lenses eating an entire stack of lenses.
Makes all lenses have a max size of 1 for safer swapping and because it just makes sense for these to not stack.
Also fixes a bug where shift clicking a lens in to the lens case would leave behind a ghost item until closing the gui.
Because I can't help myself, this also cleans up the lens selection GUI. it no longer shows duplicates, bugs out the mouse capture, doesn't swap at random if you tap the key without letting the GUI fully open, and is a lot more efficient with early returns.
Second set of fixes:
Closes GTNewHorizons/GT-New-Horizons-Modpack#20632
I extracted the custom night vision effect for lenses to it's own file to also apply it to the water lens, and I made the lens properly remove it's effects when changed or removed from an item.