Skip to content

Move pocket plane generation back to main server thread - #134

Merged
Dream-Master merged 6 commits into
masterfrom
pocket-plane-gen
Jul 11, 2026
Merged

Move pocket plane generation back to main server thread#134
Dream-Master merged 6 commits into
masterfrom
pocket-plane-gen

Conversation

@tiffit

@tiffit tiffit commented Jul 11, 2026

Copy link
Copy Markdown
Member

Summary

Does a very similar fix to #129 with a few differences:

  • Removed "generating" bool entirely as there is never a time where the dimension is being generated across multiple ticks
  • Greatly improved the speed at which the pocket plane generates (from 3.5s to 900ms on my machine)
  • Some minor code cleanup

Closes GTNewHorizons/GT-New-Horizons-Modpack#25182
Closes GTNewHorizons/GT-New-Horizons-Modpack#25794

From what I can tell, it seems to be generating properly with these changes
image

Checklist

  • I have tested this PR in DevEnv
  • I have tested this PR in Fullpack
  • This PR is in compliance with the GTNH AI Policy
  • This PR requires another PR in order to merge

@tiffit tiffit added Bug Fix Fixes a bug. Please link it in the PR if an issue exists for it. Performance Changes with the goal of improving performance. labels Jul 11, 2026
@tiffit
tiffit requested a review from Nikolay-Sitnikov July 11, 2026 07:15

@koolkrafter5 koolkrafter5 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like a good temporary fix for now to make the feature not crash. I did not find any issues with the changes.

@Dream-Master
Dream-Master merged commit b2186e9 into master Jul 11, 2026
1 check passed
@Dream-Master
Dream-Master deleted the pocket-plane-gen branch July 11, 2026 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug Fix Fixes a bug. Please link it in the PR if an issue exists for it. Performance Changes with the goal of improving performance.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Thaumcraft 4(Thaumic Horizons) Pocket Dimension creation cause crash (Daily 554) Planar Vortex Pocket Dimension Crash

3 participants