Skip to content

Conversation

@riggzh
Copy link

@riggzh riggzh commented Apr 28, 2025

After #167. Item shouldn't use display.

@Dream-Master Dream-Master requested a review from a team April 28, 2025 18:48
@Dream-Master Dream-Master added the 🚧 Testing on Zeta Do not merge yet, testing this PR on Zeta label Apr 28, 2025
@koolkrafter5 koolkrafter5 self-assigned this May 1, 2025
Copy link

@koolkrafter5 koolkrafter5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for NEI and tools made with default names, but renamed tools' names are displayed as italic.

image
image
image

In prior versions, renamed tools' names were not italic (unless anviled). Can this behavior be reimplemented? Example:
image

@riggzh
Copy link
Author

riggzh commented May 2, 2025

Now, Tool Station rename function same as anvil.
The named tool appearing in italics is considered to be as expected.

In prev version. Tool Staion will add §f in front of name.
https://discord.com/channels/181078474394566657/603348502637969419/1350835305346764930
Sometime it make framerate issue

@YannickMG
Copy link

I think italics is a good thing here. It makes it clear the item was renamed.

@riggzh riggzh requested a review from koolkrafter5 May 7, 2025 12:33
@serenibyss serenibyss removed the 🚧 Testing on Zeta Do not merge yet, testing this PR on Zeta label May 11, 2025
@serenibyss serenibyss merged commit 848656d into GTNewHorizons:master May 11, 2025
1 check passed
theTh1rt3en pushed a commit to theTh1rt3en/TinkersConstruct that referenced this pull request May 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants