Propagate CXXFLAGS correctly to setup.py #1188
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…om CMake), and remove flag trace
mglisse
approved these changes
Apr 1, 2025
Comment on lines
+366
to
+370
| if(CMAKE_BUILD_TYPE MATCHES Debug) | ||
| set(GUDHI_COMPILATION_FLAGS_STRING ${CMAKE_CXX_FLAGS_DEBUG}) | ||
| else() | ||
| set(GUDHI_COMPILATION_FLAGS_STRING ${CMAKE_CXX_FLAGS_RELEASE}) | ||
| endif() |
There was a problem hiding this comment.
I don't like hard-coding that there are only Debug and Release, there are more build types in CMake. Sadly, I think any clean way to handle it would require non-trivial changes (for instance delaying some operations from configuration to generation or even build, so we can use generator expressions). So I guess we could go with this temporarily 🙈
Comment on lines
+371
to
+372
| # Compilation flags are in a string. Transform it to a list and append them to GUDHI_PYTHON_EXTRA_COMPILE_ARGS | ||
| string(REPLACE " " ";" GUDHI_COMPILATION_FLAGS_LIST ${GUDHI_COMPILATION_FLAGS_STRING}) |
There was a problem hiding this comment.
I assume it breaks if the flags contain -I/some/dir with/a space/? It is probably already broken elsewhere in our build stuff though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When CXXFLAGS environment variable is set, with setuptools >= 74.0.0, python compilation flags are removed.
Take the ones coming from CFLAGS (as setuptools is doing before overwriting them with the CXXFLAGS environment variable value).
It also adds
CMAKE_CXX_FLAGS_RELEASE|CMAKE_CXX_FLAGS_DEBUGto setup.pyextra_compile_argsin order to add '-O3' in release mode and speed up computation.Could fix conda-forge/gudhi-feedstock#71 (to investigate)