Skip to content

Potential fix for not being able to deploy docs changes#192

Merged
GaProgMan merged 1 commit into
GaProgMan:mainfrom
jamie-taylor-rjj:bugfix/change0log-sync-permission-issue
Oct 1, 2025
Merged

Potential fix for not being able to deploy docs changes#192
GaProgMan merged 1 commit into
GaProgMan:mainfrom
jamie-taylor-rjj:bugfix/change0log-sync-permission-issue

Conversation

@jamie-taylor-rjj

Copy link
Copy Markdown
Collaborator

Rationale for this PR

This PR attempts to fix the broken docs deploy here by setting the correct permissions on the pages.yml build pipeline.

PR Checklist

Feel free to either check the following items (by place an x inside of the square brackets) or by replacing the square brackets with a relevant emoji from the following list:

  • ✅ to indicate that you have checked something off
  • ❎ to indicate that you haven't checked something off
  • ❓ to indicate that something might not be relevant (writing tests for documentation changes, for instance)

Essential

These items are essential and must be completed for each commit. If they are not completed, the PR may not be accepted.

  • [:question:] I have added tests to the OwaspHeaders.Core.Tests project
  • [:question:] I have run the dotnet-format command and fixed any .editorconfig issues
  • [:question:] I have ensured that the code coverage has not dropped below 65%
  • [:question:] I have increased the version number in OwaspHeaders.Core.csproj (only relevant for code changes)
  • [:question:] I have updated the changelog in the root of the repository
  • [:question:] I have avoided using primary constructors in the example project (see README for details)

Note

The changelog in the docs/ directory will be updated automatically when PRs are merged into main.

Optional

  • [:question:] I have documented the new feature in the docs directory
  • [:question:] I have provided a code sample, showing how someone could use the new code

Any Other Information

As this is a workflow specific change, no tests are necessary.

Warning

When merged to main, this PR may attempt to create a new release. Please cancel that build and deploy if it does.

@jamie-taylor-rjj jamie-taylor-rjj self-assigned this Oct 1, 2025
@GaProgMan

Copy link
Copy Markdown
Owner

Cancelled the build run as it isn't required.

@GaProgMan GaProgMan left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's get this merged!

@GaProgMan GaProgMan merged commit b3ea240 into GaProgMan:main Oct 1, 2025
0 of 4 checks passed
@jamie-taylor-rjj jamie-taylor-rjj deleted the bugfix/change0log-sync-permission-issue branch October 1, 2025 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants