Skip to content

Change MonitorModule to Protocol #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
GabrielSalla merged 1 commit into from
Jan 26, 2025
Merged

Change MonitorModule to Protocol #46

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 4 additions & 7 deletions src/components/monitors_loader/monitor_module_type.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,19 +1,17 @@
from types import ModuleType
from typing import TypedDict
from typing import Protocol, TypedDict

from notifications import BaseNotification
from options import AlertOptions, IssueOptions, MonitorOptions, ReactionOptions


class MonitorModule(ModuleType): # pragma: no cover
class MonitorModule(Protocol):
"""Class that represents a base monitor module structure to have a better code completion"""

monitor_options: MonitorOptions
issue_options: IssueOptions
alert_options: AlertOptions

class IssueDataType(TypedDict):
pass
class IssueDataType(TypedDict): ...

@staticmethod
async def search() -> list[IssueDataType] | None: ...
Expand All @@ -22,8 +20,7 @@ async def search() -> list[IssueDataType] | None: ...
async def update(issues_data: list[IssueDataType]) -> list[IssueDataType] | None: ...

@staticmethod
def is_solved(issue_data: IssueDataType) -> bool:
return False
def is_solved(issue_data: IssueDataType) -> bool: ...

reaction_options: ReactionOptions

Expand Down
Loading