Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds a new option for Slack notifications to re-send mentions on update. Key changes include:
- Introducing the "mention_on_update" flag in the SlackNotification class.
- Updating the notification logic to delete and resend mentions when an alert is updated.
- Adding a new test case and updating documentation accordingly.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| tests/plugins/slack/notifications/test_slack_notification.py | New test confirming mention deletion and resend when "mention_on_update" is enabled. |
| src/plugins/slack/notifications/slack_notification.py | Updated logic for handling mention re-sending and added "mention_on_update" to the SlackNotification options. |
| docs/plugins/slack.md | Documentation updated to reflect the new "mention_on_update" option (duplicate parameter entry present). |
GabrielSalla
force-pushed
the
slack-add-mention-on-update
branch
2 times, most recently
from
855583f to
fd26d55
Compare
GabrielSalla
force-pushed
the
slack-add-mention-on-update
branch
from
fd26d55 to
ee4404f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.