Support for "headless", eg. Pico Audio #15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm not sure what other code in `btstack_audio_pico.cpp` can be removed; `a2dp_sink_demo.c` seems a lot simpler, so could the whole thing be removed, if we're not doing any processing on the data?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although
pico-examplesa2dp_sink_demoworks quite well unaltered, for completeness it'd be good to have a precompiled BT speaker firmware for the Pico Audio board, rather than having to do the whole SDK setup just to compile one image. I know this is all about the blinkenlights, but in lieu of a Pico Audio-specific downloadable to do the same thing, it seems straightforward.I've done this brutally by adding a
HEADLESSconstant and#ifndef'ing the display-specific code. It could be done much cleaner, but I'd expect that'd require substantial refactoring to support an efficient "null" Display class.I suspect there's some work being done capturing the audio buffer that might be unnecessary if it's not passed out to the Display/Effect code. Is
btstack_audio_pico.cppredundant without a display? If so, how to remove it?