Forward compatibility for Gaffer 1.7 RampPlugs / shaders #6734
+66
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
I've hit the "Ready for Review" button, since I think is pretty well ready to merge - the only thing I can think of that's missing is a Changelog entry. What section does forward compatibility go in? |
Contributor
We've listed one as a Fix previously, but maybe stick this as an Improvement given that we're doing it ahead of the 1.7 release? |
danieldresser-ie
force-pushed
the
splineForward
branch
from
afc5dc3 to
4777299
Compare
Contributor
Author
|
Added Changelog entry. |
murraystevenson
force-pushed
the
splineForward
branch
from
4777299 to
864f9be
Compare
Contributor
|
Thanks Daniel! Rebased to fix the Changes.md conflict. Merging. |
github-project-automation
bot
moved this from Pending Review
to Pending release
in Work in Progress
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Copying the spline compatibility stuff from Gaffer 1.7, but running all of it backwards, to load Gaffer 1.7 ramps in Gaffer 1.6
If Murray is doing some practical testing of #6717, might make sense for him to have this available as well.