CompoundEditor-related fixes #6751
Open
+109
−44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This has several benefits : - The detached panel doesn't show up separately in task bars. - The detached panel doesn't disappear behind the main window. - The detached panel is minimised with the main window. - The detached panel correctly inherits the OCIO transform from the main window. Fixes GafferHQ#4197.
These were only kept up to date if the ScriptWindow existed when the detached panel was made, which is not the case when loading a layout.
We weren't propagating changes at all if someone had connected to `parentChangedSignal()`, because we were returning before getting the chance. We now also propagate changes when Editors are parented, as this is necessary to sync the transform into the PathListingWidget used by the LightEditor. It would be better if we weren't limiting the widgets that we're willing to propagate changes for, but I re-ran my benchmarks and doing it for everything adds ~30% overhead to the construction of a NodeEditor for `standard_surface`. Since this is slower than we'd like already, now is not the time to make it any slower.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes various problems with propagating the right display transform to LightEditors. In the process it also fixes #4197, since the solution in both cases was to parent detached panels to the main ScriptWindow. There's some fiddly code in CompoundEditor, and although I've done my best to test it all in practice, it might be good to give it a long hard stare and a firm prod before merging.