NodeBinding, PlugBinding : Remove isInstanceOf() hacks#6956
Conversation
johnhaddon
force-pushed
the
removeIsInstanceOfHacks
branch
from
21f9c40 to
186e3af
Compare
Pushed a commit to update to Cortex 10.7.0.0a11, so hopefully CI goes through now. |
johnhaddon
force-pushed
the
removeIsInstanceOfHacks
branch
2 times, most recently
from
f88272e to
933a48c
Compare
This requires some tweaks to our handling of instancers now that IECoreUSD unconditionally loads prototypes with relative paths where possible, and doesn't use a `./` prefix any more.
These optimisations are now provided universally by Cortex, in ImageEngine/cortex#1535. We have test coverage verifying this is the case already in `BoxTest.testComputeNodeCastDoesntRequirePython`.
johnhaddon
force-pushed
the
removeIsInstanceOfHacks
branch
from
933a48c to
46f8c0a
Compare
|
I've fixed the CI failures caused by the Cortex update. The new Cortex version has stuff needed for a PointInstancer Gaffer PR, and also Eric's MeshLight stuff, so it'd be great to get eyes on this today. |
murraystevenson
left a comment
murraystevenson
left a comment
There was a problem hiding this comment.
I've fixed the CI failures caused by the Cortex update. The new Cortex version has stuff needed for a PointInstancer Gaffer PR, and also Eric's MeshLight stuff, so it'd be great to get eyes on this today.
Thanks! LGTM. The only issue I've spotted is SceneViewUI._SelectionMaskPlugValueWidget needing to be updated to support the new PointInstancer, when building with this Cortex release the widget's icon is always stuck in the bright "On" state. I"m happy to see that fixed separately if getting this PR merged today would unblock other work...
Without this, the icon is always "stuck on". At some point we might want separate masks for Points and Point Instancers, but this is an easy fix that restores things to the way folks are already used to them.
|
I've pushed 91787e2 with a cheap and cheerful fix for the selection mask indicator. |
Thanks! Cheap and cheerful looks good on my end. |
github-project-automation
Bot
moved this from Pending Review
to Pending release
in Work in Progress
2 participants
These optimisations are now provided universally by Cortex, in ImageEngine/cortex#1535. We have test coverage verifying this is the case already in
BoxTest.testComputeNodeCastDoesntRequirePython.We'll need a dependencies update to include the Cortex change before CI will pass.