performed upgrade changes for wagtail 2.0 and django 2.0#5
Open
knthls wants to merge 1 commit intoGagaro:masterfrom
knthls:wagtail2.0
Open
performed upgrade changes for wagtail 2.0 and django 2.0#5knthls wants to merge 1 commit intoGagaro:masterfrom knthls:wagtail2.0
knthls wants to merge 1 commit intoGagaro:masterfrom
knthls:wagtail2.0
Conversation
Owner
|
Hi, thanks for the PR 👍 . I added a few comments. Also please fix the coding style so that the tests pass on travis. |
Gagaro
reviewed
May 16, 2018
| from wagtail.wagtailimages.tests import urls as wagtailimages_test_urls | ||
| from wagtail.wagtailsearch import urls as wagtailsearch_urls | ||
|
|
||
| #try: |
| ] | ||
| except ImproperlyConfigured: | ||
| return [ | ||
| url(r'^calendar/', include((urls,'wagtail_calendar'), namespace='wagtail_calendar')), |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
| return [ | ||
| url(r'^calendar/', include(urls, namespace='wagtail_calendar')), | ||
| ] | ||
| except ImproperlyConfigured: |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tests are passing.
I tried integrating it into an existing project and it works.