Add bidirectional dasHerd review focus - #3540
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR extends the dasHerd watcher/review tooling with a durable session mailbox plus bidirectional “Review Focus” exchange, and improves Git file inspection behavior (including UTF-8 paths and “no textual diff” cases) while preserving syntax highlighting and adding UI affordances for focused navigation.
Changes:
- Add a per-session mailbox (HTTP + WebSocket + JSONL persistence) with notification/acknowledgement lifecycle and a PowerShell CLI (
dasherd.ps1) + agent-facing protocol docs. - Introduce Focus Sets (multi-file + multi-range) and rich-client “Attention”/Focus UI: non-modal arrival, range dimming/highlights, navigation controls, and context-menu handoff (“Look at that”).
- Improve repository inspection contracts (allow empty diffs for working inspection, UTF-8 preview-path fixtures) and Windows
is_symlinkUTF-8 path handling.
Reviewed changes
Copilot reviewed 16 out of 16 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| utils/dasHerd/watcher/watcher_server.das | Adds mailbox HTTP routes, WebSocket ops, and mailbox push messages to clients. |
| utils/dasHerd/watcher/watcher_core.das | Implements mailbox storage/state, notification queuing/flushing, and Focus Set data model/validation. |
| utils/dasHerd/watcher/tests/test_watcher_core.das | Adds mailbox lifecycle tests (post/notify/fetch/ack) and queued notification behavior tests. |
| utils/dasHerd/watcher/tests/test_repository_core.das | Extends repository contract tests to allow empty working diffs and validates UTF-8 preview-path handling. |
| utils/dasHerd/watcher/tests/test_inspection_worker.das | Adds worker tests for “no-hunk patch” View preparation and UTF-8 Git-binary source View highlighting. |
| utils/dasHerd/watcher/rich_client.das | Adds Attention panel, Focus overlay rendering, selection-to-inbox posting, and error handoff context menus. |
| utils/dasHerd/watcher/repository_core.das | Adjusts diff argv construction to permit clean working inspection and strengthens relative path validation. |
| utils/dasHerd/watcher/inspection_worker.das | Enhances View preparation: support no-text-hunk scenarios and binary-as-text detection via UTF-8 validation. |
| utils/dasHerd/watcher/control.html | Adds mailbox UI (inbox/outbox) and robust token query composition; polls and renders mailbox state. |
| utils/dasHerd/PLAN.md | Links to the new agent review workflow document. |
| utils/dasHerd/GIT_TOPOLOGY_PLAN.md | Cross-references the shared focus/handoff spec document. |
| utils/dasHerd/dasherder.md | Adds agent-facing mailbox protocol/how-to documentation. |
| utils/dasHerd/dasherd.ps1 | Introduces a PowerShell CLI for mailbox operations (whoami/inbox/outbox flows). |
| utils/dasHerd/AGENT_REVIEW_WORKFLOWS.md | Adds the detailed workflow/spec document for the bidirectional focus and planned GitHub surface. |
| tests/fs/test_fs.das | Adds UTF-8 filename coverage for is_symlink. |
| src/builtin/module_builtin_fio.cpp | Fixes Windows is_symlink to use UTF-8→wide conversion before std::filesystem query. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation