Skip to content

Add bidirectional dasHerd review focus - #3540

Merged
borisbat merged 18 commits into
masterfrom
codex/herder-view-without-diff
Jul 22, 2026
Merged

Add bidirectional dasHerd review focus#3540
borisbat merged 18 commits into
masterfrom
codex/herder-view-without-diff

Conversation

@borisbat

Copy link
Copy Markdown
Collaborator

Summary

  • keep Git file viewing usable when a path has content but no textual diff, including UTF-8 worktree paths
  • add the dasHerd session mailbox CLI/protocol and document the trusted local agent interaction model
  • add bidirectional human/agent Focus Sets with exact-worktree routing, multi-file and multi-range navigation, hover captions, error handoff, and non-modal Attention UI
  • preserve syntax highlighting while dimming unrelated code and expose focused ranges in both View and Diff

Validation

  • one full PR preflight run: format, dasgen, CI-only das compilation, docs, interpreter, and JIT gates passed
  • environment skips: clang-cl and latexmk unavailable; AOT/sequence relink blocked by the running DLL-flavor host
  • local C++ small-test binary was absent, so that gate reported Not Run; CI will build it
  • post-preflight lint cleanup: 9 changed das files, 0 issues, 0 errors
  • rich client compile-only check passed
  • dasHerd watcher suite: 56 passed

Copilot AI review requested due to automatic review settings July 22, 2026 09:24

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR extends the dasHerd watcher/review tooling with a durable session mailbox plus bidirectional “Review Focus” exchange, and improves Git file inspection behavior (including UTF-8 paths and “no textual diff” cases) while preserving syntax highlighting and adding UI affordances for focused navigation.

Changes:

  • Add a per-session mailbox (HTTP + WebSocket + JSONL persistence) with notification/acknowledgement lifecycle and a PowerShell CLI (dasherd.ps1) + agent-facing protocol docs.
  • Introduce Focus Sets (multi-file + multi-range) and rich-client “Attention”/Focus UI: non-modal arrival, range dimming/highlights, navigation controls, and context-menu handoff (“Look at that”).
  • Improve repository inspection contracts (allow empty diffs for working inspection, UTF-8 preview-path fixtures) and Windows is_symlink UTF-8 path handling.

Reviewed changes

Copilot reviewed 16 out of 16 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
utils/dasHerd/watcher/watcher_server.das Adds mailbox HTTP routes, WebSocket ops, and mailbox push messages to clients.
utils/dasHerd/watcher/watcher_core.das Implements mailbox storage/state, notification queuing/flushing, and Focus Set data model/validation.
utils/dasHerd/watcher/tests/test_watcher_core.das Adds mailbox lifecycle tests (post/notify/fetch/ack) and queued notification behavior tests.
utils/dasHerd/watcher/tests/test_repository_core.das Extends repository contract tests to allow empty working diffs and validates UTF-8 preview-path handling.
utils/dasHerd/watcher/tests/test_inspection_worker.das Adds worker tests for “no-hunk patch” View preparation and UTF-8 Git-binary source View highlighting.
utils/dasHerd/watcher/rich_client.das Adds Attention panel, Focus overlay rendering, selection-to-inbox posting, and error handoff context menus.
utils/dasHerd/watcher/repository_core.das Adjusts diff argv construction to permit clean working inspection and strengthens relative path validation.
utils/dasHerd/watcher/inspection_worker.das Enhances View preparation: support no-text-hunk scenarios and binary-as-text detection via UTF-8 validation.
utils/dasHerd/watcher/control.html Adds mailbox UI (inbox/outbox) and robust token query composition; polls and renders mailbox state.
utils/dasHerd/PLAN.md Links to the new agent review workflow document.
utils/dasHerd/GIT_TOPOLOGY_PLAN.md Cross-references the shared focus/handoff spec document.
utils/dasHerd/dasherder.md Adds agent-facing mailbox protocol/how-to documentation.
utils/dasHerd/dasherd.ps1 Introduces a PowerShell CLI for mailbox operations (whoami/inbox/outbox flows).
utils/dasHerd/AGENT_REVIEW_WORKFLOWS.md Adds the detailed workflow/spec document for the bidirectional focus and planned GitHub surface.
tests/fs/test_fs.das Adds UTF-8 filename coverage for is_symlink.
src/builtin/module_builtin_fio.cpp Fixes Windows is_symlink to use UTF-8→wide conversion before std::filesystem query.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread utils/dasHerd/watcher/watcher_server.das
Comment thread utils/dasHerd/watcher/watcher_server.das Outdated
Comment thread utils/dasHerd/watcher/watcher_core.das
Copilot AI review requested due to automatic review settings July 22, 2026 09:33

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 16 out of 16 changed files in this pull request and generated 2 comments.

Comment thread utils/dasHerd/watcher/watcher_core.das
Comment thread utils/dasHerd/watcher/watcher_core.das
Copilot AI review requested due to automatic review settings July 22, 2026 09:41

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 16 out of 16 changed files in this pull request and generated 1 comment.

Comment thread src/builtin/module_builtin_fio.cpp Outdated
Copilot AI review requested due to automatic review settings July 22, 2026 09:49

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 16 out of 16 changed files in this pull request and generated 1 comment.

Comment thread utils/dasHerd/watcher/watcher_core.das Outdated
Copilot AI review requested due to automatic review settings July 22, 2026 09:55

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 16 out of 16 changed files in this pull request and generated 4 comments.

Comment thread utils/dasHerd/watcher/watcher_server.das
Comment thread utils/dasHerd/watcher/watcher_server.das Outdated
Comment thread utils/dasHerd/watcher/watcher_server.das
Comment thread utils/dasHerd/watcher/rich_client.das Outdated
Copilot AI review requested due to automatic review settings July 22, 2026 10:06

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 16 out of 16 changed files in this pull request and generated 1 comment.

Comment thread utils/dasHerd/watcher/watcher_core.das Outdated
Copilot AI review requested due to automatic review settings July 22, 2026 10:11

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 16 out of 16 changed files in this pull request and generated 1 comment.

Comment thread utils/dasHerd/watcher/inspection_worker.das Outdated
Copilot AI review requested due to automatic review settings July 22, 2026 10:17

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 16 out of 16 changed files in this pull request and generated 1 comment.

Comment thread utils/dasHerd/watcher/rich_client.das Outdated
Copilot AI review requested due to automatic review settings July 22, 2026 10:23

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 16 out of 16 changed files in this pull request and generated no new comments.

@borisbat
borisbat merged commit f6f78c4 into master Jul 22, 2026
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants