rtti: retain named-module initializer hashes - #3543
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes how RTTI records a structure’s generated initializer mangled-name hash (StructInfo.init_mnh) when the structure lives in a named module, and adds a regression test to ensure the hash matches the corresponding function’s FuncInfo.hash.
Changes:
- Resolve generated structure initializers via the module’s
functionsByNameindex (simple-name lookup) instead offindFunctionon an unmangled name. - Select the matching zero-argument function that returns the exact structure before recording
init_mnh. - Add a named-module RTTI regression test and document it in the tests README.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tests/README.md | Adds the new RTTI regression test to the language tests list. |
| tests/language/test_rtti_init_mnh.das | New regression ensuring StructInfo.init_mnh matches the initializer FuncInfo.hash in a named module. |
| src/ast/ast_debug_info_helper.cpp | Updates RTTI debug-info emission to find the correct initializer function in named modules and store its mangled-name hash. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation