render tool errors as llmxml - #39
Merged
Merged
Conversation
Success output speaks llmxml (ADR 1.3); errors were the one surface breaking the dialect, reaching the model as bare prose. Receiving middleware rewraps in-band error text as <error tool="NAME">message</error> at one choke point covering SDK argument validation, client-side refusals, and Gerrit API passthrough alike; per-handler wrapping would miss validation errors, which never reach handler code. Protocol-level failures (unknown tool) stay JSON-RPC errors; the MCP isError flag is untouched. Error shape is pinned by golden files alongside success renders.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All in-band tool-call errors — SDK argument validation, client-side refusals, Gerrit API passthrough — now reach the model wrapped as
<error tool="NAME">message</error>, applied by a single receiving middleware so validation errors (which never reach handler code) are covered too. Protocol-level failures stay JSON-RPC errors; the MCPisErrorflag is untouched.ADR 1.3 amended: error shape joins the published output contract, pinned by golden files.
Verified live against Gerrit: validation, wrong-type, Gerrit-400 passthrough all wrapped; unknown-tool remains a JSON-RPC error.