Skip to content

Add 3.14 testing to CI and fix one 3.14 issue - #1338

Closed
braingram wants to merge 2 commits into
GalSim-developers:mainfrom
braingram:3p14
Closed

Add 3.14 testing to CI and fix one 3.14 issue#1338
braingram wants to merge 2 commits into
GalSim-developers:mainfrom
braingram:3p14

Conversation

@braingram

@braingram braingram commented Oct 25, 2025

Copy link
Copy Markdown

I was able to successfully run the python unit tests with python 3.14. I noticed one warning:

galsim/setup.py:1369: SyntaxWarning: "\." is an invalid escape sequence. Such sequences will not work in the future. Did you mean "\\."? A raw string is also an option.
  vi = re.split('\.|-',galsim_version)

This PR fixes the above invalid escape (#1335 also fixes the same regex in the same way) and adds 3.14 to the CI.

Is main the correct branch to target for these changes?

Also if this warrants a changelog entry please let me know where to add one. Thanks!

@braingram
braingram marked this pull request as ready for review October 25, 2025 00:26
@rmjarvis

Copy link
Copy Markdown
Member

Thanks Brett. There are some other fixes on #1335 that would be needed to get the CI to pass here. So rather than port them over, I just added the 3.14 addition to that PR. So I'm closing this one. But thanks for checking that everything works fine in 3.14.

@rmjarvis rmjarvis closed this Oct 27, 2025
@braingram
braingram deleted the 3p14 branch October 27, 2025 22:36
@braingram

Copy link
Copy Markdown
Author

Thanks!

@rmjarvis rmjarvis added this to the v2.8 milestone Dec 27, 2025
@rmjarvis rmjarvis added build Related to compiling, building, installing tests Related to the test suite labels May 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build Related to compiling, building, installing tests Related to the test suite

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants