Blatt17

[GalacticCodeGambit]

No description provided.

[Copilot]

Pull request overview

This PR extends LazyCook with (1) password reset (“Passwort vergessen” + Reset-Link per Mail + Reset-Page), (2) ingredient-usage tracking to show “Top 5” ingredient suggestions in the recipe finder popup, and (3) markdown-rendered legal pages (Impressum/Datenschutz). It also splits linting into a dedicated GitHub Actions workflow and refactors parts of the frontend auth/profile UI.

Changes:

• Added forgot/reset-password flow end-to-end (backend routes + email template + frontend pages/modals).
• Added ingredient usage tracking + “Top ingredients” API and frontend suggestion badges with localStorage caching.
• Added markdown rendering utilities and pages for Impressum/Datenschutz; added separate lint workflow and README updates.

Reviewed changes

Copilot reviewed 37 out of 38 changed files in this pull request and generated 11 comments.

Show a summary per file

File	Description
README.md	Adds setup/lint docs and badges; installation instructions updated.
project/frontend/package.json	Adds react-markdown + remark-gfm dependencies for markdown pages.
project/frontend/lib/auth.tsx	Makes API base URL configurable; adjusts token handling and authenticated fetch logic.
project/frontend/app/reset-password/page.tsx	New reset-password page consuming the token query param and calling backend reset endpoint.
project/frontend/app/recipeFinder/style.css	Adds styling for ingredient suggestion badges and stacked popup fields.
project/frontend/app/recipeFinder/popup.tsx	Adds “Top 5” ingredient suggestion badge UI and focus handling.
project/frontend/app/recipeFinder/page.tsx	Loads/caches suggestions, updates them after search, and passes them into the popup.
project/frontend/app/profile/page.tsx	Refactors profile settings to use reusable modal components for email/password change and deletion confirm.
project/frontend/app/profile/changePasswordPopup.tsx	New change-password popup component (used from profile).
project/frontend/app/profile/changeEmailPopup.tsx	New change-email popup component (used from profile).
project/frontend/app/lib/read-markdown.ts	Server-side helper to read markdown files from the homepage markdown directory.
project/frontend/app/layout.tsx	Fixes global stylesheet import name.
project/frontend/app/impressum/page.tsx	New Impressum page rendering existing markdown via renderer.
project/frontend/app/homepage/signin.tsx	Adds “Passwort vergessen?” entry point and improves error classification.
project/frontend/app/homepage/MarkdownFiles/Impressum.md	Adds Impressum markdown content.
project/frontend/app/homepage/MarkdownFiles/Datenschutz.md	Adds Datenschutzerklärung markdown content.
project/frontend/app/homepage/homepage.tsx	Adds navbar links to legal pages and a “forgot password” modal state.
project/frontend/app/homepage/forgotPassword.tsx	New forgot-password modal form calling backend request endpoint.
project/frontend/app/globals.css	Fixes a CSS variable typo (10 px → 10px).
project/frontend/app/datenschutz/page.tsx	New Datenschutz page rendering existing markdown via renderer.
project/frontend/app/components/markdown-renderer.tsx	New markdown renderer component using react-markdown + GFM.
project/frontend/app/components/fields.tsx	Enhances Field component with password show/hide toggle.
project/Dockerfile-frontend	Pins Node image tag more specifically.
project/compose.yaml	Adds FRONTEND_URL env var for backend to build reset links / CORS origin.
project/backend/SearchRecipeNames.py	Adds helper to find recipes by name substring.
project/backend/Routes.py	Adds forgot/reset-password endpoints; adds recipes search usage tracking + top ingredients endpoints; adjusts refresh account mapping.
project/backend/RecipeSUCUK.py	Adds/updates recipe search algorithm draft (SUCUK).
project/backend/Recipe.py	Refactors recipe model, persistence helpers, and matching/rating helpers.
project/backend/Models.py	Extends Token model + adds request models for password reset and recipe search.
project/backend/LazyCookAdministration.py	Makes CORS allowed origin configurable via FRONTEND_URL.
project/backend/Ingridient.py	Removes old misspelled Ingredient class file.
project/backend/Ingredient.py	Adds new Ingredient class file.
project/backend/EmailService.py	Adds password-reset email sending helper.
project/backend/Database.py	Enables WAL; renames Ingredient table; adds IngredientUsage + PasswordResetToken tables and new helper queries.
project/backend/Auth.py	Adds password reset token generation/validation.
docs/Review-Protokoll-01.md	Adds a review protocol document.
.github/workflows/lint.yml	Introduces dedicated lint workflow using GitHub Super-Linter.
.github/workflows/ci.yml	Removes linter job from CI workflow (now in lint.yml).

Comments suppressed due to low confidence (4)

project/backend/Database.py:281

• getIngridientByName ist aktuell kaputt: es selektiert aus Recipe und vergleicht id = ?, obwohl der Parameter name heißt. Außerdem wird (name) statt (name,) übergeben. Das führt dazu, dass Ingredient-Lookups fehlschlagen. Bitte auf SELECT id, amountType FROM Ingredient WHERE name = ? umstellen und korrektes Tuple verwenden.

def getIngridientByName(name: str):
    with getDB() as con:
        cur = con.cursor()
        cur.execute(
            """
                    SELECT id, amountType
                    FROM Recipe
                    WHERE id = ?
                    """,
            (name),
        )
        row = cur.fetchone()
        return dict(row) if row else None

project/backend/Database.py:345

• Die SQL in getAllocatedRecipes ist syntaktisch/inhaltlich fehlerhaft (Komma nach JOIN, Where nach Komma, Join-Bedingung rid=id ist unklar, Exists_from.id scheint nicht zu existieren). Bitte Query korrigieren oder die Funktion entfernen, falls ungenutzt.

def getAllocatedRecipes(name: str) -> list[dict]:

    with getDB() as con:
        cur = con.cursor()
        cur.execute(
            """
                    SELECT rid 
                    FROM Exists_from
                    Inner Join Ingredient on rid=id,
                    Where Exists_from.id = ?
                    """,
            (name,),
        )
        rows = cur.fetchall()
        return [dict(row) for row in rows]

project/backend/Recipe.py:66

• Die Methode heißt getingredients, aber der SUCUK-Algorithmus nutzt getIngredients() / recipe.getIngredients(). Dadurch gibt es zur Laufzeit einen AttributeError. Bitte die Methode konsistent benennen (und ggf. alle Call-Sites anpassen).

    def getingredients(self) -> list[Ingredient]:
        return self.__ingredients

    def setIngredient(self, ingredients: list[Ingredient]):
        self.__ingredients = ingredients

project/backend/Database.py:69

• Schema-Änderung: initDB() erstellt jetzt eine Tabelle Ingredient (statt zuvor Ingridient). Da die DB in project/data persistiert wird, bleibt eine bestehende alte Tabelle unverändert bestehen (keine Migration) und Queries, die Ingredient erwarten, können auf älteren Datenbanken fehlschlagen. Bitte Migration/Kompatibilität (Rename/Copy) vorsehen oder wenigstens beim Startup prüfen und eine klare Fehlermeldung geben.

        cur.execute("""
                    CREATE TABLE IF NOT EXISTS Ingredient (
                                                         id INTEGER PRIMARY KEY AUTOINCREMENT,
                                                         name TEXT UNIQUE NOT NULL,
                                                         amountType VARCHAR(30) NOT NULL
                        )
                    """)

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.