Skip to content
This repository was archived by the owner on May 18, 2025. It is now read-only.

disambig template#95

Open
donthaveausername wants to merge 4 commits into
Galaxypedia-Wiki:mainfrom
donthaveausername:main
Open

disambig template#95
donthaveausername wants to merge 4 commits into
Galaxypedia-Wiki:mainfrom
donthaveausername:main

Conversation

@donthaveausername

@donthaveausername donthaveausername commented Jan 21, 2025

Copy link
Copy Markdown

added a disambiguation template (#80) and updated disambiguation pages to use the template

moved galaxy image files from the disambiguation page to the ship page

also contains changes from PR #88 because i accidentally closed that

donthaveausername and others added 4 commits January 5, 2025 22:28
converted a few pages to markdown and fixed their formatting, as well as edited some of them to fit wiki guidelines.
Co-authored-by: cswimr <seaswimmerthefsh@gmail.com>
added a disambiguation template and updated pages to use the template (issue Galaxypedia-Wiki#80)

also moved the galaxy images to the ship page instead of the disambig page
@donthaveausername donthaveausername requested review from a team as code owners January 21, 2025 04:58
@github-actions github-actions Bot added site:content Concerns site content site:shortcodes Concerns shortcodes labels Jan 21, 2025
@smallketchup82

smallketchup82 commented Jan 21, 2025

Copy link
Copy Markdown
Member

for future reference, do not open pull requests from the main branch of your fork. its bad practice and likely what led to you combining two changes in one PR. git branching is very powerful and you should put in the effort to learn it, it'll help you out a lot

@smallketchup82 smallketchup82 self-requested a review January 26, 2025 06:07
@smallketchup82

Copy link
Copy Markdown
Member

ok so despite my numerous attempts at getting seaswimmer's input on how to approach this pr, he has not given me a definitive answer.

i'll probably edit the history on this branch and remove the changes from #88

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

site:content Concerns site content site:shortcodes Concerns shortcodes size/L

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants