Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor encoders #1583

Open
wants to merge 5 commits into
base: dev
Choose a base branch
from
Open

Refactor encoders #1583

wants to merge 5 commits into from

Conversation

Arusekk
Copy link
Member

@Arusekk Arusekk commented Jun 14, 2020

Most changes to ARM alphanumeric (reduced duplication and fixed indentation).

Fix code style and python 3 compatibility,
reduce code duplication.
Lots of whitespace changes.  Best to view with git diff -w
@zachriggle
Copy link
Member

I know you put a lot of effort into refactoring the ARM encoders, but I'm hesitant to do so without working tests (since the encoders have all been broken for some time). All of the code was lifted from an academic paper, so any diversion from that is a maintenance burden.

@heapcrash heapcrash added this to the Someday milestone Jun 16, 2020
@heapcrash
Copy link
Collaborator

Agree with @zachriggle it would be nice to get the encoders working and tested before refactoring / rewriting them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants