Skip to content

fix(ssh): preserve ANSI escape codes in interactive mode (closes #2703) #2747

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Gustavo-Blois wants to merge 3 commits into
base: dev
Choose a base branch
from
Open

fix(ssh): preserve ANSI escape codes in interactive mode (closes #2703) #2747

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
06a243a
fix(ssh): preserve ANSI escape codes in interactive mode
Gustavo-Blois Jun 9, 2026
556b536
chore: update changelog for #2747
Gustavo-Blois Jun 9, 2026
f24063d
Merge branch 'dev' into fix/ssh-interactive-ansi
peace-maker Jun 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ The table below shows which release corresponds to each branch, and what date th
| [2.2.0](#220) | | Jan 5, 2015

## 5.0.0 (`dev`)

- [#2747][2747] fix(ssh): preserve ANSI escape codes in interactive mode (closes #2703)
- [#2740][2740] setup: install docs to FHS-compliant share/doc/pwntools
- [#2739][2739] shellcraft: migrate lazy importer to find_spec for Python 3.12+
- [#2725][2725] feat(libcdb): add extra_mirrors arg + PWNLIB_EXTRA_LIBC_MIRRORS env to download_libraries
Expand Down Expand Up @@ -139,6 +139,7 @@ The table below shows which release corresponds to each branch, and what date th
- [#2733][2733] loongarch64: fix incorrect mov assembly template
- [#2746][2746] elf: point people at libc_start_main_return when they look up __libc_start_main_ret

[2747]: https://github.com/Gallopsled/pwntools/pull/2747
[2675]: https://github.com/Gallopsled/pwntools/pull/2675
[2652]: https://github.com/Gallopsled/pwntools/pull/2652
[2638]: https://github.com/Gallopsled/pwntools/pull/2638
Expand Down
5 changes: 2 additions & 3 deletions pwnlib/tubes/ssh.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -232,9 +232,8 @@ def recv_thread(event):
elif cur == b'\a':
# Ugly hack until term unstands bell characters
continue
stdout = sys.stdout
if not term.term_mode:
stdout = getattr(stdout, 'buffer', stdout)

stdout = getattr(sys.stdout, 'buffer', sys.stdout)
stdout.write(cur)
stdout.flush()
except EOFError:
Expand Down