-
Notifications
You must be signed in to change notification settings - Fork 72
MIR backend: Support nightly-2025-02-16
#2323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
RyanGlScott
wants to merge
14
commits into
master
Choose a base branch
from
saw-rust-1.86
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ci skip]
sauclovian-g
approved these changes
May 13, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks reasonable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates SAW and
crux-mir-comp
in order to support a more recent Rust nightly (nightly-2025-02-16
). This piggybacks off of the correspondingmir-json
changes in GaloisInc/mir-json#98 (a fix for GaloisInc/mir-json#78), as well as the{crucible,crux}-mir
changes in GaloisInc/crucible#1396.Most of the interesting changes are on the Crucible side in GaloisInc/crucible#1396. The code in SAW that had to change:
mirRef_offsetSim
no longer takes aTypeRepr
argument, so some code incrux-mir-comp
had to be adjusted accordingly.DefId
s for lang items (e.g.,$lang::Option
), theDefId
lookup logic now takes into account the newlang_items
table in a MIR JSON file.This also updates all of the vendored-in
*.linked-mir.json
files andcrux-mir-comp
test cases to use updated line number information.The commit history in this branch is a little messy, so I will rebase and squash it before landing it.