Fix WM_HOTKEY handling to prevent unintended message propagation #413
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When
gHotkeyIgnoreCount > 0
, theWM_HOTKEY
message handler breaks out of the switch statement instead of returning early. This allows the message to propagate toDefWindowProc
, potentially triggering unintended hotkey behavior in other applications (e.g., if the same hotkey is registered elsewhere).Solution
Replacing the
break
statement withreturn 0
in theWM_HOTKEY
ignore block ensures the message is marked as "handled," preventing further propagation.