Skip to content

Conversation

@EpyonProjects
Copy link
Member

@EpyonProjects EpyonProjects commented Nov 5, 2024

Adds creepers, withers, and wither skulls alongside TNT creating ore lumps when destroying stone

@misode
Copy link
Member

misode commented Nov 5, 2024

Would it be better to detect the #is_explosion damage type tag? Or is that not possible in block loot tables?

@EpyonProjects
Copy link
Member Author

Hmm.. I was thinking about how to future proof this or to add expansion compatibility, but I'm not sure how or where to input a tag

@misode misode added the feature-update An additional feature has been added to a module label Nov 12, 2024
@EpyonProjects
Copy link
Member Author

Oh, the stone entry at the bottom uses "survives explosion", wouldn't that be sufficient? Just any explosion?

@misode
Copy link
Member

misode commented Nov 25, 2024

Oh, the stone entry at the bottom uses "survives explosion", wouldn't that be sufficient? Just any explosion?

That condition always succeeds for tnt explosions and has a chance of failing (based on distance) for other explosions. But it also always succeeds for any other block destroy cause. It's present in most vanilla blocks.

@misode misode merged commit 57b7eb3 into Gamemode4Dev:master Nov 25, 2024
3 checks passed
github-actions bot pushed a commit that referenced this pull request Nov 25, 2024
@EpyonProjects EpyonProjects deleted the metallurgy-add-other-explosions branch November 25, 2024 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature-update An additional feature has been added to a module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants