Fix disassembling tools in 1.21.1 #1069
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When updating the packs to 1.21.2, I noticed that the recipes used some new item tags. I changed the disassemblers beet code to use them, but didn't notice that this would break the 1.21.1 version of the pack.
The proper way to implement this would be reading the 1.21.1 vanilla recipe files to generate the loot tables, but that's a whole bunch of overlays. Since the recipes themselves didn't change, adding a copy of the vanilla files is a lot easier.
I tested this locally to make sure the fix works.