-
-
Notifications
You must be signed in to change notification settings - Fork 64
Make beet.yaml video field optional
#1225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I believe that this was an intentional decision. Keeping
What is easily forgotten? Adding the field? It shouldn't be if you either copy bat grenades or follow the making-a-module docs.
This is intended. They are part of the better armour stands video. |
…into video-optional
204ccbc to
392505f
Compare
Ah I totally missed that, woops. That change has been reverted |
misode
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm still not convinced that we even need this at all, but it looks good in that this would work.
I disagree. The majority of our modules does not have videos, in fact, it has been years since we have made a module video. Videos are no longer the default, they are the exception. Hence having to put a boiler-plate |
A majority of our modules have no video, so in the
beet.yamlthe field sits as null. This is easily forgotten, as has happened several times in new module PRs.This PR makes the field optional as well as cleaning up existing video fields in all modules
beet.yamlfiles.video: nullfields have been removed. They would still work, I just figured I'd clean them up while I was hereParticles Pack and Poses Pack each had their video link adjusted to no longer include a time argument