Skip to content

Conversation

@runcows
Copy link
Contributor

@runcows runcows commented Dec 3, 2025

A majority of our modules have no video, so in the beet.yaml the field sits as null. This is easily forgotten, as has happened several times in new module PRs.

This PR makes the field optional as well as cleaning up existing video fields in all modules beet.yaml files.

  • video: null fields have been removed. They would still work, I just figured I'd clean them up while I was here
  • XP storages video link has been adjusted to no longer point to a playlist
  • Particles Pack and Poses Pack each had their video link adjusted to no longer include a time argument

@runcows runcows changed the title Make video field optional Make beet.yaml video field optional Dec 3, 2025
@misode
Copy link
Member

misode commented Dec 6, 2025

I believe that this was an intentional decision. Keeping video: null in all the beet.yaml files makes it clear where you can place the video link. I don't see any advantage in this tbh.

This is easily forgotten, as has happened several times in new module PRs.

What is easily forgotten? Adding the field? It shouldn't be if you either copy bat grenades or follow the making-a-module docs.

Particles Pack and Poses Pack each had their video link adjusted to no longer include a time argument

This is intended. They are part of the better armour stands video.

@runcows
Copy link
Contributor Author

runcows commented Dec 6, 2025

They are part of the better armour stands video.

Ah I totally missed that, woops. That change has been reverted

Copy link
Member

@misode misode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm still not convinced that we even need this at all, but it looks good in that this would work.

@Bloo-dev
Copy link
Member

Bloo-dev commented Dec 8, 2025

I believe that this was an intentional decision. Keeping video: null in all the beet.yaml files makes it clear where you can place the video link. I don't see any advantage in this tbh.

I disagree. The majority of our modules does not have videos, in fact, it has been years since we have made a module video. Videos are no longer the default, they are the exception. Hence having to put a boiler-plate video: null on every module even though they are never gonna get a video seems a bit silly.

@Bloo-dev Bloo-dev added the tool This is related to our build pipeline label Dec 8, 2025
@misode misode merged commit ef8a755 into Gamemode4Dev:master Dec 8, 2025
4 checks passed
github-actions bot pushed a commit that referenced this pull request Dec 8, 2025
* Make video field optional

* Remove null video fields

* Modify xp storage video link to not link to a playlist

* Remove RP null video field

* Update docs

* Review comments

* Review part 2
@runcows runcows deleted the video-optional branch December 10, 2025 01:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

tool This is related to our build pipeline

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants