fixed Image.getBounds and Quad.getBounds for non-zero upper left vertex case. #408
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ex case. Texture's frame could be used to align images that is a rasterized version of a flash symbol that have a custom pivot (in the center of an image for example). In order to get correct bounds (and therefore hitTest) one has to consider upper left vertex of an Image (Quad).
Contributor
|
Sorry that I didn't comment on this earlier! It has been a while since I browsed over the open pull requests. :-| The frame support is something that I want to improve in the future (see #522). When that's done, I can look into your idea, as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Texture's frame could be used to align images that is a rasterized
version of a flash symbol that have a custom pivot (in the center of an
image for example). In order to get correct bounds (and therefore
hitTest) one has to consider upper left vertex of an Image (Quad).