Repository navigation
Conversation
… as HomeKeyService does
|
maintainer-bot review · this one needs a maintainer decision Thanks for the PR! Couldn't review this one automatically; it goes to the maintainer. Checks
Reviewed by maintainer-bot · runs on 0G Private Computer |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HomeKeyServiceisdirectBootAwarebecause, as its own comment says, Android 11 skips a service that is not while the user is still locked at boot, writesaccessibility_enabled=0and, on TCL G03 firmware, never binds it after the unlock.InputKeyServicedid not have the flag, so a setup with onlyINPUT_KEY_SERVICE=1(noHomeKeyServiceto keep the switch on) is exposed to the same skip.InputKeyServicenow declares the flag and, likeHomeKeyService, waits forACTION_USER_UNLOCKEDbefore everything that reads credential-protected storage (Config.load,ServiceRepair.connected, the gamepad listener); until then it has no mappings, so keys pass through except the Input button itself. It staysexported="false". Found by reading the code; the reboot case was tried on a TV that does not show the skip (below).The CVTE bullet in
docs/TROUBLESHOOTING.mdlists the components that declare the flag; it now namesInputKeyServicetoo (tests/test_thomson_40fg2s14w_note.pychecks that list against the manifest).Tested on: TCL Q6 (G10), Google TV 14, build UTT2.250416.001
On the TV,
InputKeyServicealone on the list (noHomeKeyService),app_keys: ["29:<YouTube>"], reboot: after bootaccessibility_enabledis 1,InputKeyServiceis bound, and the button (the key pressed through a USB keyboard (so it reaches the helpers the way a remote button does;input keyeventdoes not reach them on this set)) opens YouTube. Only this branch was rebooted (not main), so the run shows the flag and the unlock wait break nothing here; it does not reproduce the G03 skip.gradlew --no-daemon testReleaseUnitTest lintRelease assembleRelease: BUILD SUCCESSFUL, unit tests pass, lint 0 errors (98 warnings, as on main), release APK 587,381 B (main: 587,321 B, +60 B; gate 589,824 B).python -m unittest discover -s tests: 3209 tests, OK (522 skipped: the POSIX-shell and pwsh suites, which CI runs).test_thomson_40fg2s14w_note,test_helper_table,test_key_filterand others): OK;test_thomson_40fg2s14w_notefails with the new flag until the bullet names the component.UserManagerand a bound service, which the plain JVM tests cannot build.Overlaps #3599, which adds a field and lines at the same places in
InputKeyService(field block, top ofonServiceConnected, top ofonDestroy); whichever merges second needs a small rebase, which I will push.If this touches the launcher
values/strings.xmland the othervalues-*folders (n/a, no strings)config.xmlor a theme, not in codeReviewed with cross-review 1.2.1 (SkillArray, MIT license): https://github.com/M-khalifa/SkillArray